milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix misuse of waitgroup in metrics mutex ut (#26865) 

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
pull/26881/head
congqixia 2023-09-06 12:39:14 +08:00 committed by GitHub
parent 2f32623d16
commit 7e2fa55440
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/util/lock/metrics_mutex_test.go
View File

@ -23,15 +23,15 @@ func TestMetricsLockLock(t *testing.T) {
testRWLock := lManager.applyRWLock(lName)
wg := sync.WaitGroup{}
testRWLock.Lock("main_thread")
wg.Add(1)
go func() {
wg.Add(1)
defer wg.Done()
before := time.Now()
testRWLock.Lock("sub_thread")
lkDuration := time.Since(before)
assert.True(t, lkDuration >= lockDuration)
testRWLock.UnLock("sub_threadXX")
testRWLock.UnLock("sub_thread")
wg.Done()
}()
time.Sleep(lockDuration)
testRWLock.UnLock("main_thread")
@ -52,14 +52,14 @@ func TestMetricsLockRLock(t *testing.T) {
testRWLock := lManager.applyRWLock(lName)
wg := sync.WaitGroup{}
testRWLock.RLock("main_thread")
wg.Add(1)
go func() {
wg.Add(1)
defer wg.Done()
before := time.Now()
testRWLock.Lock("sub_thread")
lkDuration := time.Since(before)
assert.True(t, lkDuration >= lockDuration)
testRWLock.UnLock("sub_thread")
wg.Done()
}()
time.Sleep(lockDuration)
assert.Equal(t, 1, len(testRWLock.acquireTimeMap))