milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Move createColumnInfo out of ParserContext (#8558) 

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
pull/8639/head
Cai Yudong 2021-09-27 09:47:57 +08:00 committed by GitHub
parent de6a3d96a8
commit 7e0a49125c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
internal/proxy/plan_parser.go
View File

@ -179,8 +179,8 @@ func parseExpr(schema *typeutil.SchemaHelper, exprStr string) (*planpb.Expr, err
return nil, optimizer.err
}
context := ParserContext{schema}
expr, err := context.handleExpr(&ast.Node)
pc := ParserContext{schema}
expr, err := pc.handleExpr(&ast.Node)
if err != nil {
return nil, err
}
@ -188,7 +188,7 @@ func parseExpr(schema *typeutil.SchemaHelper, exprStr string) (*planpb.Expr, err
return expr, nil
}
func (context *ParserContext) createColumnInfo(field *schemapb.FieldSchema) *planpb.ColumnInfo {
func createColumnInfo(field *schemapb.FieldSchema) *planpb.ColumnInfo {
return &planpb.ColumnInfo{
FieldId: field.FieldID,
DataType: field.DataType,
@ -301,8 +301,8 @@ func (context *ParserContext) createCmpExpr(left, right ant_ast.Node, operator s
expr := &planpb.Expr{
Expr: &planpb.Expr_CompareExpr{
CompareExpr: &planpb.CompareExpr{
LeftColumnInfo: context.createColumnInfo(leftField),
RightColumnInfo: context.createColumnInfo(rightField),
LeftColumnInfo: createColumnInfo(leftField),
RightColumnInfo: createColumnInfo(rightField),
Op: op,
},
},
@ -343,7 +343,7 @@ func (context *ParserContext) createCmpExpr(left, right ant_ast.Node, operator s
expr := &planpb.Expr{
Expr: &planpb.Expr_UnaryRangeExpr{
UnaryRangeExpr: &planpb.UnaryRangeExpr{
ColumnInfo: context.createColumnInfo(field),
ColumnInfo: createColumnInfo(field),
Op: op,
Value: val,
},
@ -422,7 +422,7 @@ func (context *ParserContext) handleInExpr(node *ant_ast.BinaryNode) (*planpb.Ex
expr := &planpb.Expr{
Expr: &planpb.Expr_TermExpr{
TermExpr: &planpb.TermExpr{
ColumnInfo: context.createColumnInfo(field),
ColumnInfo: createColumnInfo(field),
Values: arrayData,
},
},