From 729d409a323945595fb4ee910560b379d5a978b8 Mon Sep 17 00:00:00 2001
From: "cai.zhang" <cai.zhang@zilliz.com>
Date: Wed, 22 Sep 2021 19:36:00 +0800
Subject: [PATCH] Add trace log for search (#8302)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
---
internal/proxy/impl.go | 2 ++
internal/proxy/task.go | 8 ++++++++
2 files changed, 10 insertions(+)
diff --git a/internal/proxy/impl.go b/internal/proxy/impl.go
index 564610b209..2613ee1eed 100644
--- a/internal/proxy/impl.go
+++ b/internal/proxy/impl.go
@@ -1418,6 +1418,8 @@ func (node *Proxy) Search(ctx context.Context, request *milvuspb.SearchRequest)
Status: unhealthyStatus(),
}, nil
}
+ sp, ctx := trace.StartSpanFromContextWithOperationName(ctx, "Proxy-Search")
+ defer sp.Finish()
qt := &searchTask{
ctx: ctx,
Condition: NewTaskCondition(ctx),
diff --git a/internal/proxy/task.go b/internal/proxy/task.go
index 1e207e0cd6..dd91ed1291 100644
--- a/internal/proxy/task.go
+++ b/internal/proxy/task.go
@@ -27,6 +27,8 @@ import (
"time"
"unsafe"
+ "github.com/milvus-io/milvus/internal/util/trace"
+
"github.com/milvus-io/milvus/internal/common"
"go.uber.org/zap"
@@ -1439,6 +1441,8 @@ func (st *searchTask) getVChannels() ([]vChan, error) {
}
func (st *searchTask) PreExecute(ctx context.Context) error {
+ sp, ctx := trace.StartSpanFromContextWithOperationName(st.TraceCtx(), "Proxy-Search-PreExecute")
+ defer sp.Finish()
st.Base.MsgType = commonpb.MsgType_Search
st.Base.SourceID = Params.ProxyID
@@ -1630,6 +1634,8 @@ func (st *searchTask) PreExecute(ctx context.Context) error {
}
func (st *searchTask) Execute(ctx context.Context) error {
+ sp, ctx := trace.StartSpanFromContextWithOperationName(st.TraceCtx(), "Proxy-Search-Execute")
+ defer sp.Finish()
var tsMsg msgstream.TsMsg = &msgstream.SearchMsg{
SearchRequest: *st.SearchRequest,
BaseMsg: msgstream.BaseMsg{
@@ -1957,6 +1963,8 @@ func reduceSearchResultData(searchResultData []*schemapb.SearchResultData, avail
//}
func (st *searchTask) PostExecute(ctx context.Context) error {
+ sp, ctx := trace.StartSpanFromContextWithOperationName(st.TraceCtx(), "Proxy-Search-PostExecute")
+ defer sp.Finish()
t0 := time.Now()
defer func() {
log.Debug("WaitAndPostExecute", zap.Any("time cost", time.Since(t0)))