milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[skip ci] Fix golint of reloadFromKV (#12735) 

Signed-off-by: xige-16 <xi.ge@zilliz.com>
pull/12693/head
xige-16 2021-12-06 10:05:41 +08:00 committed by GitHub
parent a2a1f9d08c
commit 6d9a93ef37
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
internal/querycoord/cluster.go
View File

@ -166,7 +166,7 @@ func (c *queryNodeCluster) reloadFromKV() error {
onlineSessionMap[nodeID] = session onlineSessionMap[nodeID] = session
} }
for nodeID, session := range onlineSessionMap { for nodeID, session := range onlineSessionMap {
log.Debug("ReloadFromKV: register a queryNode to cluster", zap.Any("nodeID", nodeID)) log.Debug("reloadFromKV: register a queryNode to cluster", zap.Any("nodeID", nodeID))
err := c.registerNode(c.ctx, session, nodeID, disConnect) err := c.registerNode(c.ctx, session, nodeID, disConnect)
if err != nil { if err != nil {
log.Error("query node failed to register", zap.Int64("nodeID", nodeID), zap.String("error info", err.Error())) log.Error("query node failed to register", zap.Int64("nodeID", nodeID), zap.String("error info", err.Error()))
@ -185,19 +185,19 @@ func (c *queryNodeCluster) reloadFromKV() error {
for index := range oldStringNodeIDs { for index := range oldStringNodeIDs {
nodeID, err := strconv.ParseInt(filepath.Base(oldStringNodeIDs[index]), 10, 64) nodeID, err := strconv.ParseInt(filepath.Base(oldStringNodeIDs[index]), 10, 64)
if err != nil { if err != nil {
log.Error("WatchNodeLoop: parse nodeID error", zap.Error(err)) log.Error("watchNodeLoop: parse nodeID error", zap.Error(err))
return err return err
} }
if _, ok := onlineSessionMap[nodeID]; !ok { if _, ok := onlineSessionMap[nodeID]; !ok {
session := &sessionutil.Session{} session := &sessionutil.Session{}
err = json.Unmarshal([]byte(oldNodeSessions[index]), session) err = json.Unmarshal([]byte(oldNodeSessions[index]), session)
if err != nil { if err != nil {
log.Error("WatchNodeLoop: unmarshal session error", zap.Error(err)) log.Error("watchNodeLoop: unmarshal session error", zap.Error(err))
return err return err
} }
err = c.registerNode(context.Background(), session, nodeID, offline) err = c.registerNode(context.Background(), session, nodeID, offline)
if err != nil { if err != nil {
log.Debug("ReloadFromKV: failed to add queryNode to cluster", zap.Int64("nodeID", nodeID), zap.String("error info", err.Error())) log.Debug("reloadFromKV: failed to add queryNode to cluster", zap.Int64("nodeID", nodeID), zap.String("error info", err.Error()))
return err return err
} }
toLoadMetaNodeIDs = append(toLoadMetaNodeIDs, nodeID) toLoadMetaNodeIDs = append(toLoadMetaNodeIDs, nodeID)
@ -219,10 +219,10 @@ func (c *queryNodeCluster) reloadFromKV() error {
} }
err = c.nodes[nodeID].setCollectionInfo(collectionInfo) err = c.nodes[nodeID].setCollectionInfo(collectionInfo)
if err != nil { if err != nil {
log.Debug("ReloadFromKV: failed to add queryNode meta to cluster", zap.Int64("nodeID", nodeID), zap.String("error info", err.Error())) log.Debug("reloadFromKV: failed to add queryNode meta to cluster", zap.Int64("nodeID", nodeID), zap.String("error info", err.Error()))
return err return err
} }
log.Debug("ReloadFromKV: reload collection info from etcd", zap.Any("info", collectionInfo)) log.Debug("reloadFromKV: reload collection info from etcd", zap.Any("info", collectionInfo))
} }
} }
return nil return nil