Merge branch 'branch-0.4.0' into 'branch-0.4.0'

MS-306 - Optimize build efficiency

See merge request megasearch/milvus!297

Former-commit-id: fe4fdc6b9f677c01de6ff8c05165fce8350c5657

cpp/cmake/ThirdPartyPackages.cmake

@@ -2033,7 +2033,7 @@ macro(build_zstd)
 
 
     set(ZSTD_STATIC_LIB "${ZSTD_PREFIX}/lib/libzstd.a")
-
+    set(ZSTD_INCLUDE_DIR "${ZSTD_PREFIX}/include")
     set(ZSTD_CMAKE_ARGS
             ${ZSTD_CMAKE_ARGS}
             -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
@@ -2045,28 +2045,61 @@ macro(build_zstd)
         message(FATAL_ERROR "Building zstd using ExternalProject requires at least CMake 3.7")
     endif()
 
-    externalproject_add(zstd_ep
+    if(USE_JFROG_CACHE STREQUAL "ON")
-            ${EP_LOG_OPTIONS}
+        set(ZSTD_CACHE_PACKAGE_NAME "zstd_${ZSTD_MD5}.tar.gz")
-            CMAKE_ARGS
+        set(ZSTD_CACHE_URL "${JFROG_ARTFACTORY_CACHE_URL}/${ZSTD_CACHE_PACKAGE_NAME}")
-            ${ZSTD_CMAKE_ARGS}
+        set(ZSTD_CACHE_PACKAGE_PATH "${THIRDPARTY_PACKAGE_CACHE}/${ZSTD_CACHE_PACKAGE_NAME}")
-            SOURCE_SUBDIR
-            "build/cmake"
-            BUILD_COMMAND
-            ${MAKE}
-            ${MAKE_BUILD_ARGS}
-            INSTALL_DIR
-            ${ZSTD_PREFIX}
-            URL
-            ${ZSTD_SOURCE_URL}
-            BUILD_BYPRODUCTS
-            "${ZSTD_STATIC_LIB}")
 
-    file(MAKE_DIRECTORY "${ZSTD_PREFIX}/include")
+        file(DOWNLOAD ${ZSTD_CACHE_URL} ${ZSTD_CACHE_PACKAGE_PATH} STATUS status)
+        list(GET status 0 status_code)
+        message(STATUS "DOWNLOADING FROM ${ZSTD_CACHE_URL} TO ${ZSTD_CACHE_PACKAGE_PATH}. STATUS = ${status_code}")
+        if (NOT status_code EQUAL 0)
+            externalproject_add(zstd_ep
+                    ${EP_LOG_OPTIONS}
+                    CMAKE_ARGS
+                    ${ZSTD_CMAKE_ARGS}
+                    SOURCE_SUBDIR
+                    "build/cmake"
+                    BUILD_COMMAND
+                    ${MAKE}
+                    ${MAKE_BUILD_ARGS}
+                    INSTALL_DIR
+                    ${ZSTD_PREFIX}
+                    URL
+                    ${ZSTD_SOURCE_URL}
+                    BUILD_BYPRODUCTS
+                    "${ZSTD_STATIC_LIB}")
+
+            ExternalProject_Create_Cache(zstd_ep ${ZSTD_CACHE_PACKAGE_PATH} "${CMAKE_CURRENT_BINARY_DIR}/zstd_ep-prefix" ${JFROG_USER_NAME} ${JFROG_PASSWORD} ${ZSTD_CACHE_URL})
+
+            file(MAKE_DIRECTORY "${ZSTD_INCLUDE_DIR}")
+        else()
+            ExternalProject_Use_Cache(zstd_ep ${ZSTD_CACHE_PACKAGE_PATH} ${CMAKE_CURRENT_BINARY_DIR})
+        endif()
+    else()
+        externalproject_add(zstd_ep
+                ${EP_LOG_OPTIONS}
+                CMAKE_ARGS
+                ${ZSTD_CMAKE_ARGS}
+                SOURCE_SUBDIR
+                "build/cmake"
+                BUILD_COMMAND
+                ${MAKE}
+                ${MAKE_BUILD_ARGS}
+                INSTALL_DIR
+                ${ZSTD_PREFIX}
+                URL
+                ${ZSTD_SOURCE_URL}
+                BUILD_BYPRODUCTS
+                "${ZSTD_STATIC_LIB}")
+
+        file(MAKE_DIRECTORY "${ZSTD_INCLUDE_DIR}")
+    endif()
 
     add_library(zstd STATIC IMPORTED)
     set_target_properties(zstd
             PROPERTIES IMPORTED_LOCATION "${ZSTD_STATIC_LIB}"
-            INTERFACE_INCLUDE_DIRECTORIES "${ZSTD_PREFIX}/include")
+            INTERFACE_INCLUDE_DIRECTORIES "${ZSTD_INCLUDE_DIR}")
 
     add_dependencies(zstd zstd_ep)
 endmacro()
@@ -2100,7 +2133,7 @@ macro(build_aws)
             "${AWS_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-core${CMAKE_STATIC_LIBRARY_SUFFIX}")
     set(AWS_CPP_SDK_S3_STATIC_LIB
             "${AWS_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}aws-cpp-sdk-s3${CMAKE_STATIC_LIBRARY_SUFFIX}")
-
+    set(AWS_INCLUDE_DIR "${AWS_PREFIX}/include")
     set(AWS_CMAKE_ARGS
             ${AWS_CMAKE_ARGS}
             -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
@@ -2108,33 +2141,66 @@ macro(build_aws)
             -DCMAKE_C_FLAGS=${EP_C_FLAGS}
             -DCMAKE_CXX_FLAGS=${EP_CXX_FLAGS})
 
-    externalproject_add(aws_ep
+    if(USE_JFROG_CACHE STREQUAL "ON")
-            ${EP_LOG_OPTIONS}
+        set(AWS_CACHE_PACKAGE_NAME "aws_${AWS_MD5}.tar.gz")
-            CMAKE_ARGS
+        set(AWS_CACHE_URL "${JFROG_ARTFACTORY_CACHE_URL}/${AWS_CACHE_PACKAGE_NAME}")
-            ${AWS_CMAKE_ARGS}
+        set(AWS_CACHE_PACKAGE_PATH "${THIRDPARTY_PACKAGE_CACHE}/${AWS_CACHE_PACKAGE_NAME}")
-            BUILD_COMMAND
+
-            ${MAKE}
+        file(DOWNLOAD ${AWS_CACHE_URL} ${AWS_CACHE_PACKAGE_PATH} STATUS status)
-            ${MAKE_BUILD_ARGS}
+        list(GET status 0 status_code)
-            INSTALL_DIR
+        message(STATUS "DOWNLOADING FROM ${AWS_CACHE_URL} TO ${AWS_CACHE_PACKAGE_PATH}. STATUS = ${status_code}")
-            ${AWS_PREFIX}
+        if (NOT status_code EQUAL 0)
-            URL
+            externalproject_add(aws_ep
-            ${AWS_SOURCE_URL}
+                    ${EP_LOG_OPTIONS}
-            BUILD_BYPRODUCTS
+                    CMAKE_ARGS
-            "${AWS_CPP_SDK_S3_STATIC_LIB}"
+                    ${AWS_CMAKE_ARGS}
-            "${AWS_CPP_SDK_CORE_STATIC_LIB}")
+                    BUILD_COMMAND
-    file(MAKE_DIRECTORY "${AWS_PREFIX}/include")
+                    ${MAKE}
+                    ${MAKE_BUILD_ARGS}
+                    INSTALL_DIR
+                    ${AWS_PREFIX}
+                    URL
+                    ${AWS_SOURCE_URL}
+                    BUILD_BYPRODUCTS
+                    "${AWS_CPP_SDK_S3_STATIC_LIB}"
+                    "${AWS_CPP_SDK_CORE_STATIC_LIB}")
+
+            ExternalProject_Create_Cache(aws_ep ${AWS_CACHE_PACKAGE_PATH} "${CMAKE_CURRENT_BINARY_DIR}/aws_ep-prefix" ${JFROG_USER_NAME} ${JFROG_PASSWORD} ${AWS_CACHE_URL})
+
+            file(MAKE_DIRECTORY "${AWS_INCLUDE_DIR}")
+        else()
+            ExternalProject_Use_Cache(aws_ep ${AWS_CACHE_PACKAGE_PATH} ${CMAKE_CURRENT_BINARY_DIR})
+        endif()
+    else()
+        externalproject_add(aws_ep
+                ${EP_LOG_OPTIONS}
+                CMAKE_ARGS
+                ${AWS_CMAKE_ARGS}
+                BUILD_COMMAND
+                ${MAKE}
+                ${MAKE_BUILD_ARGS}
+                INSTALL_DIR
+                ${AWS_PREFIX}
+                URL
+                ${AWS_SOURCE_URL}
+                BUILD_BYPRODUCTS
+                "${AWS_CPP_SDK_S3_STATIC_LIB}"
+                "${AWS_CPP_SDK_CORE_STATIC_LIB}")
+
+        file(MAKE_DIRECTORY "${AWS_INCLUDE_DIR}")
+    endif()
 
     add_library(aws-cpp-sdk-s3 STATIC IMPORTED)
     set_target_properties(aws-cpp-sdk-s3
             PROPERTIES
             IMPORTED_LOCATION "${AWS_CPP_SDK_S3_STATIC_LIB}"
-            INTERFACE_INCLUDE_DIRECTORIES "${AWS_PREFIX}/include"
+            INTERFACE_INCLUDE_DIRECTORIES "${AWS_INCLUDE_DIR}"
             INTERFACE_LINK_LIBRARIES "${AWS_PREFIX}/lib/libaws-c-event-stream.a;${AWS_PREFIX}/lib/libaws-checksums.a;${AWS_PREFIX}/lib/libaws-c-common.a")
 
     add_library(aws-cpp-sdk-core STATIC IMPORTED)
     set_target_properties(aws-cpp-sdk-core
             PROPERTIES IMPORTED_LOCATION "${AWS_CPP_SDK_CORE_STATIC_LIB}"
-            INTERFACE_INCLUDE_DIRECTORIES "${AWS_PREFIX}/include"
+            INTERFACE_INCLUDE_DIRECTORIES "${AWS_INCLUDE_DIR}"
             INTERFACE_LINK_LIBRARIES "${AWS_PREFIX}/lib/libaws-c-event-stream.a;${AWS_PREFIX}/lib/libaws-checksums.a;${AWS_PREFIX}/lib/libaws-c-common.a")
 
     add_dependencies(aws-cpp-sdk-s3 aws_ep)