milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: fix chunk cache madvise when sparse raw data is mmaped (#39145) 

instead of marking as not supported,
`ChunkedSparseFloatColumn::DataByteSize` can simply use the impl of
super class.

issue: https://github.com/milvus-io/milvus/issues/39158

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
pull/39212/head
Buqian Zheng 2025-01-13 10:34:57 +08:00 committed by GitHub
parent 3cd74037db
commit 640a49ffb6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
internal/core/src/mmap/ChunkedColumn.h
View File

@ -282,14 +282,6 @@ class ChunkedSparseFloatColumn : public ChunkedColumnBase {
std::dynamic_pointer_cast<SparseFloatVectorChunk>(chunk)->Dim());
}
// This is used to advice mmap prefetch, we don't currently support mmap for
// sparse float vector thus not implemented for now.
size_t
DataByteSize() const override {
PanicInfo(ErrorCode::Unsupported,
"ByteSize not supported for sparse float column");
}
SpanBase
Span(int64_t chunk_id) const override {
PanicInfo(ErrorCode::Unsupported,
@ -303,7 +295,6 @@ class ChunkedSparseFloatColumn : public ChunkedColumnBase {
private:
int64_t dim_ = 0;
std::vector<knowhere::sparse::SparseRow<float>> vec_;
};
template <typename T>