milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix data race in ShardCluster.SyncReplicas (#18054) 

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
pull/17971/head
congqixia 2022-07-05 13:16:20 +08:00 committed by GitHub
parent d652fa567a
commit 63230f0280
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/querynode/shard_cluster.go
View File

@ -301,6 +301,8 @@ func (sc *ShardCluster) SyncSegments(distribution []*querypb.ReplicaSegmentsInfo
})
}
}
allocations := sc.segments.Clone(filterNothing)
sc.mut.Unlock()
// notify handoff wait online if any
@ -310,7 +312,7 @@ func (sc *ShardCluster) SyncSegments(distribution []*querypb.ReplicaSegmentsInfo
sc.mutVersion.Lock()
defer sc.mutVersion.Unlock()
version := NewShardClusterVersion(sc.nextVersionID.Inc(), sc.segments.Clone(filterNothing))
version := NewShardClusterVersion(sc.nextVersionID.Inc(), allocations)
sc.versions.Store(version.versionID, version)
sc.currentVersion = version
}