milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

enhance: [skip e2e]to add some comments (#29440) 

there are two purposes for this PR
1. to add some comments on variable in the .env file. 
2. avoid git merge conflict when one PR update the value of DATE_VERSION
and LATEST_DATE_VERSION and meanwhile other PR updates the value of
GPU_DATE_VERSION and LATEST_GPU_DATE_VERSION , especailly when github
actions Publish Builder and Publish gpu Builder occur at same time

Signed-off-by: Sammy Huang <sammy.huang@zilliz.com>
pull/29442/head
sammy.huang 2023-12-25 10:28:47 +08:00 committed by GitHub
parent 7c916b1035
commit 62fdfe125f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
.env
View File

@ -1,10 +1,18 @@
# to define environment variables available to docker-compose.yml
IMAGE_REPO=milvusdb
IMAGE_ARCH=amd64
OS_NAME=ubuntu20.04
# for services.builder.image in docker-compose.yml
DATE_VERSION=20231212-4651f89
LATEST_DATE_VERSION=20231212-4651f89
# for services.gpubuilder.image in docker-compose.yml
GPU_DATE_VERSION=20231212-4651f89
LATEST_GPU_DATE_VERSION=20231212-4651f89
# for other services in docker-compose.yml
MINIO_ADDRESS=minio:9000
PULSAR_ADDRESS=pulsar://pulsar:6650
ETCD_ENDPOINTS=etcd:2379

4
build/builder.sh
View File

@ -6,7 +6,9 @@ set -euo pipefail
toplevel=$(dirname "$(cd "$(dirname "${0}")"; pwd)")
if [[ -f "$toplevel/.env" ]]; then
export $(cat $toplevel/.env | xargs)
set -a # automatically export all variables from .env
source $toplevel/.env
set +a # stop automatically exporting
fi
pushd "${toplevel}"