run hadolint with reviewdog (#1060)

* run hadolint with reviewdog

* add LINCENSE in Dockerfile

* run hadolint with reviewdog

* Reporter of reviewdog command is "github-pr-check"

* format Dockerfile

* ignore DL3007 in hadolint

.github/workflows/core.yml

@@ -5,10 +5,12 @@ on:
     paths:
       - 'ci/**'
       - 'core/**'
+      - 'docker/**'
   pull_request:
     paths:
       - 'ci/**'
       - 'core/**'
+      - 'docker/**'
 
 jobs:
   ubuntu:
@@ -23,6 +25,11 @@ jobs:
     steps:
       - name: Checkout Milvus
         uses: actions/checkout@v1
+      - name: Check Dockerfile
+        uses: mgrachev/action-hadolint@v1
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          reporter: github-pr-check # Default is github-pr-check
       - name: Docker Pull
         shell: bash
         run: |
@@ -65,6 +72,11 @@ jobs:
     steps:
       - name: Checkout Milvus
         uses: actions/checkout@v1
+      - name: Check Dockerfile
+        uses: mgrachev/action-hadolint@v1
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          reporter: github-pr-check # Default is github-pr-check
       - name: Docker Pull
         shell: bash
         run: |

.hadolint.yaml

@@ -0,0 +1,4 @@
+ignored:
+  - DL3003
+  - DL3007
+  - DL3008

core/src/index/thirdparty/SPTAG/Dockerfile

@@ -6,9 +6,13 @@ COPY AnnService ./AnnService/
 COPY Test ./Test/
 COPY Wrappers ./Wrappers/
 
-RUN apt-get update && apt-get -y install wget build-essential \
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+RUN apt-get update && apt-get install -y --no-install-recommends wget build-essential \
     # remove the following if you don't want to build the wrappers
-    openjdk-8-jdk python3-pip swig
+    openjdk-8-jdk python3-pip swig && \
+    apt-get remove --purge -y && \
+    rm -rf /var/lib/apt/lists/*
 
 # cmake >= 3.12 is required
 RUN wget "https://github.com/Kitware/CMake/releases/download/v3.14.4/cmake-3.14.4-Linux-x86_64.tar.gz" -q -O - \

core/src/index/thirdparty/faiss/Dockerfile

@@ -22,7 +22,7 @@ WORKDIR /opt/faiss
 
 # --with-cuda=/usr/local/cuda-8.0 
 RUN ./configure --prefix=/usr --libdir=/usr/lib64 --without-cuda
-RUN make -j $(nproc)
+RUN make -j "$(nproc)"
 RUN make -C python
 RUN make test
 RUN make install

docker/build_env/cpu/centos7/Dockerfile

@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 FROM centos:centos7
 
 SHELL ["/bin/bash", "-o", "pipefail", "-c"]

docker/build_env/cpu/ubuntu16.04/Dockerfile

@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 FROM ubuntu:16.04
 
 ENV DEBIAN_FRONTEND noninteractive

docker/build_env/cpu/ubuntu18.04/Dockerfile

@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 FROM ubuntu:18.04
 
 ENV DEBIAN_FRONTEND noninteractive

docker/build_env/gpu/centos7/Dockerfile

@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 FROM nvidia/cuda:10.1-devel-centos7
 
 ENV NVIDIA_DRIVER_CAPABILITIES compute,utility

docker/build_env/gpu/ubuntu16.04/Dockerfile

@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 FROM nvidia/cuda:10.1-devel-ubuntu16.04
 
 ENV NVIDIA_DRIVER_CAPABILITIES compute,utility

docker/build_env/gpu/ubuntu18.04/Dockerfile

@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 FROM nvidia/cuda:10.1-devel-ubuntu18.04
 
 ENV NVIDIA_DRIVER_CAPABILITIES compute,utility

docker/deploy/cpu/centos7/Dockerfile

@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 FROM centos:centos7
 
 RUN yum install -y epel-release && \

docker/deploy/cpu/ubuntu16.04/Dockerfile

@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 FROM ubuntu:16.04
 
 RUN apt-get update && apt-get install -y --no-install-recommends \

docker/deploy/cpu/ubuntu18.04/Dockerfile

@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 FROM ubuntu:18.04
 
 RUN apt-get update && apt-get install -y --no-install-recommends \

docker/deploy/gpu/centos7/Dockerfile

@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 FROM nvidia/cuda:10.1-devel-centos7
 
 ENV NVIDIA_DRIVER_CAPABILITIES compute,utility

docker/deploy/gpu/ubuntu16.04/Dockerfile

@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 FROM nvidia/cuda:10.1-devel-ubuntu16.04
 
 ENV NVIDIA_DRIVER_CAPABILITIES compute,utility

docker/deploy/gpu/ubuntu18.04/Dockerfile

@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 FROM nvidia/cuda:10.1-devel-ubuntu18.04
 
 ENV NVIDIA_DRIVER_CAPABILITIES compute,utility

docker/test_env/Dockerfile

@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 FROM python:3.6.8-jessie
 
 SHELL ["/bin/bash", "-o", "pipefail", "-c"]

shards/Dockerfile

@@ -1,10 +1,12 @@
 FROM python:3.6
-RUN apt update && apt install -y \
+RUN apt-get update && apt-get install -y --no-install-recommends \
     less \
-    telnet
+    telnet && \
+    apt-get remove --purge -y && \
+    rm -rf /var/lib/apt/lists/*
 RUN mkdir /source
 WORKDIR /source
-ADD ./requirements.txt ./
+COPY ./requirements.txt ./
 RUN pip install -r requirements.txt
 COPY . .
-CMD python mishards/main.py
+CMD ["python", "mishards/main.py"]

tests/milvus_python_test/Dockerfile

@@ -3,12 +3,13 @@ FROM python:3.6.8-jessie
 LABEL Name=megasearch_engine_test Version=0.0.1
 
 WORKDIR /app
-ADD . /app
+COPY . /app
 
 RUN apt-get update && apt-get install -y --no-install-recommends \
     libc-dev build-essential && \
     python3 -m pip install -r requirements.txt && \
-    apt-get remove --purge -y 
+    apt-get remove --purge -y && \
+    rm -rf /var/lib/apt/lists/*
 
 ENTRYPOINT [ "/app/docker-entrypoint.sh" ]
 CMD [ "start" ]