milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

enhance: tidy compaction logs (#37595) 

Remove some annoying logs and lower a log level from warn to info

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
pull/37625/head
XuanYang-cn 2024-11-12 21:18:29 +08:00 committed by GitHub
parent 14e007d6fb
commit 5ab3c562da
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
internal/datacoord/compaction_policy_l0.go
View File

@ -30,7 +30,6 @@ func (policy *l0CompactionPolicy) Enable() bool {
}
func (policy *l0CompactionPolicy) Trigger() (map[CompactionTriggerType][]CompactionView, error) {
log.Info("start trigger l0CompactionPolicy...")
// support config hot refresh
events := policy.generateEventForLevelZeroViewChange()
if len(events) != 0 {

17
internal/datacoord/compaction_policy_single.go
View File

@ -47,7 +47,6 @@ func (policy *singleCompactionPolicy) Enable() bool {
}
func (policy *singleCompactionPolicy) Trigger() (map[CompactionTriggerType][]CompactionView, error) {
log.Info("start trigger singleCompactionPolicy...")
ctx := context.Background()
collections := policy.meta.GetCollections()
@ -67,14 +66,14 @@ func (policy *singleCompactionPolicy) Trigger() (map[CompactionTriggerType][]Com
func (policy *singleCompactionPolicy) triggerOneCollection(ctx context.Context, collectionID int64, manual bool) ([]CompactionView, int64, error) {
log := log.With(zap.Int64("collectionID", collectionID))
log.Info("start trigger single compaction")
collection, err := policy.handler.GetCollection(ctx, collectionID)
if err != nil {
log.Warn("fail to get collection from handler")
log.Warn("fail to apply singleCompactionPolicy, unable to get collection from handler",
zap.Error(err))
return nil, 0, err
}
if collection == nil {
log.Warn("collection not exist")
log.Warn("fail to apply singleCompactionPolicy, collection not exist")
return nil, 0, nil
}
if !isCollectionAutoCompactionEnabled(collection) {
@ -84,7 +83,7 @@ func (policy *singleCompactionPolicy) triggerOneCollection(ctx context.Context,
newTriggerID, err := policy.allocator.AllocID(ctx)
if err != nil {
log.Warn("fail to allocate triggerID", zap.Error(err))
log.Warn("fail to apply singleCompactionPolicy, unable to allocate triggerID", zap.Error(err))
return nil, 0, err
}
@ -106,7 +105,7 @@ func (policy *singleCompactionPolicy) triggerOneCollection(ctx context.Context,
collectionTTL, err := getCollectionTTL(collection.Properties)
if err != nil {
log.Warn("get collection ttl failed, skip to handle compaction")
log.Warn("failed to apply singleCompactionPolicy, get collection ttl failed")
return make([]CompactionView, 0), 0, err
}
@ -124,7 +123,11 @@ func (policy *singleCompactionPolicy) triggerOneCollection(ctx context.Context,
}
}
log.Info("finish trigger single compaction", zap.Int("viewNum", len(views)))
if len(views) > 0 {
log.Info("succeeded to apply singleCompactionPolicy",
zap.Int64("triggerID", newTriggerID),
zap.Int("triggered view num", len(views)))
}
return views, newTriggerID, nil
}

2
internal/datacoord/compaction_task_mix.go
View File

@ -78,7 +78,7 @@ func (t *mixCompactionTask) processPipelining() bool {
t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_pipelining), setNodeID(NullNodeID))
return false
}
log.Warn("mixCompactionTask notify compaction tasks to DataNode")
log.Info("mixCompactionTask notify compaction tasks to DataNode")
err = t.updateAndSaveTaskMeta(setState(datapb.CompactionTaskState_executing))
if err != nil {