milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Leader checker canot submit load task (#30067) 

issue: #29841
if segment loaded, submit load segment task for it isn't permitted, to
avoid load segment twice. but this logic blocks the leader checker to
correct leader view by `LoadSegment`

This PR remove the segment loaded check, to fix that leader checker
cann't submit load task

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
pull/30083/head
wei liu 2024-01-17 19:12:54 +08:00 committed by GitHub
parent 31740445fa
commit 57bd3e2181
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
internal/querycoordv2/task/scheduler.go
View File

@ -329,14 +329,7 @@ func (scheduler *taskScheduler) preAdd(task Task) error {
taskType := GetTaskType(task)
if taskType == TaskTypeGrow {
leaderSegmentDist := scheduler.distMgr.LeaderViewManager.GetSealedSegmentDist(task.SegmentID())
nodeSegmentDist := scheduler.distMgr.SegmentDistManager.GetSegmentDist(task.SegmentID())
if lo.Contains(leaderSegmentDist, task.Actions()[0].Node()) &&
lo.Contains(nodeSegmentDist, task.Actions()[0].Node()) {
return merr.WrapErrServiceInternal("segment loaded, it can be only balanced")
}
} else if taskType == TaskTypeMove {
if taskType == TaskTypeMove {
leaderSegmentDist := scheduler.distMgr.LeaderViewManager.GetSealedSegmentDist(task.SegmentID())
nodeSegmentDist := scheduler.distMgr.SegmentDistManager.GetSegmentDist(task.SegmentID())
if !lo.Contains(leaderSegmentDist, task.Actions()[1].Node()) ||