milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[skip e2e]Add comments for skip e2e tag (#13581) 

Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
pull/13659/head
yanliang567 2021-12-17 18:52:28 +08:00 committed by GitHub
parent cc7f4b1e02
commit 577e25a542
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
CODE_REVIEW.md
View File

@ -4,7 +4,9 @@ All PRs are checked in automatically by the sre-robot, with the following condit
1. DCO check passed
2. All test passed and code coverage check passed, with a `ci-passed` label
3. Reviewe passed, with a `lgtm` label
- Notes: If there is a `[skip e2e]` tag in the commit message, it skips running e2e tests automatically,
but it still runs UT tests and code checkers.
3. Reviewer passed, with a `lgtm` label
4. Approver passed, with a `approved` label
Generally speaking, reviewer is volunteered and can be anyone in the community who is familiar with the packages the PR modifies.
@ -43,6 +45,9 @@ all Approvers are listed under OWNERS_ALIASES file.
- Are hacks, workarounds and temporary fixes commented?
- If `[skip e2e]` is tagged, is it safe enough to skip running e2e tests?
- Notes: it skips running e2e tests, if there is a `[skip e2e]` in the commit message.
## Things to keep in mind when you are writing a review comment
- Be kind to the coder, not to the code.