milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[skip e2e]Remove useless grpc comment (#14428) 

Signed-off-by: sunby <bingyi.sun@zilliz.com>

Co-authored-by: sunby <bingyi.sun@zilliz.com>
pull/14436/head
Bingyi Sun 2021-12-28 16:17:51 +08:00 committed by GitHub
parent 4233e4e5be
commit 572ca4bb97
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
internal/util/grpcclient/client.go
View File

@ -119,6 +119,7 @@ func (c *ClientBase) connect(ctx context.Context) error {
opts := trace.GetInterceptorOpts()
dialContext, cancel := context.WithTimeout(ctx, dialTimeout)
// refer to https://github.com/grpc/grpc-proto/blob/master/grpc/service_config/service_config.proto
retryPolicy := `{
"methodConfig": [{
"name": [{}],
@ -145,9 +146,9 @@ func (c *ClientBase) connect(ctx context.Context) error {
grpc.WithStreamInterceptor(grpcopentracing.StreamClientInterceptor(opts...)),
grpc.WithDefaultServiceConfig(retryPolicy),
grpc.WithKeepaliveParams(keepalive.ClientParameters{
Time: keepAliveTime, // send pings every 60 seconds if there is no activity
Timeout: keepAliveTimeout, // wait 6 second for ping ack before considering the connection dead
PermitWithoutStream: true, // send pings even without active streams
Time: keepAliveTime,
Timeout: keepAliveTimeout,
PermitWithoutStream: true,
}),
grpc.WithConnectParams(grpc.ConnectParams{
Backoff: backoff.Config{