milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix get collection by id (#19507) 

Signed-off-by: longjiquan <jiquan.long@zilliz.com>

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
pull/19244/head
Jiquan Long 2022-09-28 19:26:54 +08:00 committed by GitHub
parent 03a3599453
commit 5550f883de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/rootcoord/meta_table.go
View File

@ -91,9 +91,7 @@ type IMetaTable interface {
ListAliasesByID(collID UniqueID) []string
// TODO: better to accept ctx.
GetCollectionNameByID(collID UniqueID) (string, error) // [Deprecated].
GetPartitionNameByID(collID UniqueID, partitionID UniqueID, ts Timestamp) (string, error) // serve for bulk load.
GetCollectionIDByName(name string) (UniqueID, error) // [Deprecated].
GetPartitionByName(collID UniqueID, partitionName string, ts Timestamp) (UniqueID, error) // serve for bulk load.
// TODO: better to accept ctx.

42
internal/rootcoord/mocks/IMetaTable.go
View File

@ -248,48 +248,6 @@ func (_m *IMetaTable) GetCollectionByName(ctx context.Context, collectionName st
return r0, r1
}
// GetCollectionIDByName provides a mock function with given fields: name
func (_m *IMetaTable) GetCollectionIDByName(name string) (int64, error) {
ret := _m.Called(name)
var r0 int64
if rf, ok := ret.Get(0).(func(string) int64); ok {
r0 = rf(name)
} else {
r0 = ret.Get(0).(int64)
}
var r1 error
if rf, ok := ret.Get(1).(func(string) error); ok {
r1 = rf(name)
} else {
r1 = ret.Error(1)
}
return r0, r1
}
// GetCollectionNameByID provides a mock function with given fields: collID
func (_m *IMetaTable) GetCollectionNameByID(collID int64) (string, error) {
ret := _m.Called(collID)
var r0 string
if rf, ok := ret.Get(0).(func(int64) string); ok {
r0 = rf(collID)
} else {
r0 = ret.Get(0).(string)
}
var r1 error
if rf, ok := ret.Get(1).(func(int64) error); ok {
r1 = rf(collID)
} else {
r1 = ret.Error(1)
}
return r0, r1
}
// GetCollectionVirtualChannels provides a mock function with given fields: colID
func (_m *IMetaTable) GetCollectionVirtualChannels(colID int64) []string {
ret := _m.Called(colID)

2
internal/rootcoord/root_coord.go
View File

@ -810,7 +810,7 @@ func (c *Core) describeCollection(ctx context.Context, in *milvuspb.DescribeColl
if in.GetCollectionName() != "" {
return c.meta.GetCollectionByName(ctx, in.GetCollectionName(), ts)
}
return c.meta.GetCollectionByID(ctx, in.GetCollectionID(), in.GetTimeStamp())
return c.meta.GetCollectionByID(ctx, in.GetCollectionID(), ts)
}
func convertModelToDesc(collInfo *model.Collection, aliases []string) *milvuspb.DescribeCollectionResponse {