mirror of https://github.com/milvus-io/milvus.git
enhance: Remove legacy L0 segment if watch failed (#32725)
Like growing segments, legacy l0 segments shall be removed if watch dml channel execution fails as well. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>pull/32642/head
parent
83ce352885
commit
53b5f1be17
|
@ -293,18 +293,22 @@ func (node *QueryNode) WatchDmChannels(ctx context.Context, req *querypb.WatchDm
|
|||
})
|
||||
delegator.AddExcludedSegments(growingInfo)
|
||||
|
||||
err = loadL0Segments(ctx, delegator, req)
|
||||
if err != nil {
|
||||
log.Warn("failed to load l0 segments", zap.Error(err))
|
||||
return merr.Status(err), nil
|
||||
}
|
||||
defer func() {
|
||||
if err != nil {
|
||||
// remove legacy growing
|
||||
node.manager.Segment.RemoveBy(ctx, segments.WithChannel(channel.GetChannelName()),
|
||||
segments.WithType(segments.SegmentTypeGrowing))
|
||||
// remove legacy l0 segments
|
||||
node.manager.Segment.RemoveBy(segments.WithChannel(channel.GetChannelName()),
|
||||
segments.WithLevel(datapb.SegmentLevel_L0))
|
||||
}
|
||||
}()
|
||||
|
||||
err = loadL0Segments(ctx, delegator, req)
|
||||
if err != nil {
|
||||
log.Warn("failed to load l0 segments", zap.Error(err))
|
||||
return merr.Status(err), nil
|
||||
}
|
||||
err = loadGrowingSegments(ctx, delegator, req)
|
||||
if err != nil {
|
||||
msg := "failed to load growing segments"
|
||||
|
|
Loading…
Reference in New Issue