milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

enhance: Use defer to clean legacy growing segment (#30770) 

See also #30735 #30735

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
pull/30757/head
congqixia 2024-02-23 10:02:55 +08:00 committed by GitHub
parent 90e802e441
commit 536e082f5a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
internal/querynodev2/services.go
View File

@ -319,11 +319,15 @@ func (node *QueryNode) WatchDmChannels(ctx context.Context, req *querypb.WatchDm
log.Warn("failed to load l0 segments", zap.Error(err))
return merr.Status(err), nil
}
defer func() {
if err != nil {
// remove legacy growing
node.manager.Segment.RemoveBy(segments.WithChannel(channel.GetChannelName()),
segments.WithType(segments.SegmentTypeGrowing))
}
}()
err = loadGrowingSegments(ctx, delegator, req)
if err != nil {
// remove legacy growing
node.manager.Segment.RemoveBy(segments.WithChannel(channel.GetChannelName()),
segments.WithType(segments.SegmentTypeGrowing))
msg := "failed to load growing segments"
log.Warn(msg, zap.Error(err))
return merr.Status(err), nil