milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

enhance: [2.4] use the rate log in the privilege interceptor (#32038) 

/kind improvement
pr: #32037

Signed-off-by: SimFG <bang.fu@zilliz.com>
pull/32073/head
SimFG 2024-04-09 16:37:17 +08:00 committed by GitHub
parent 8475a63d72
commit 4a4935f7b2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/proxy/privilege_interceptor.go
View File

@ -88,10 +88,10 @@ func PrivilegeInterceptor(ctx context.Context, req interface{}) (context.Context
return ctx, nil
}
log := log.Ctx(ctx)
log.Debug("PrivilegeInterceptor", zap.String("type", reflect.TypeOf(req).String()))
log.RatedDebug(60, "PrivilegeInterceptor", zap.String("type", reflect.TypeOf(req).String()))
privilegeExt, err := funcutil.GetPrivilegeExtObj(req)
if err != nil {
log.Info("GetPrivilegeExtObj err", zap.Error(err))
log.RatedInfo(60, "GetPrivilegeExtObj err", zap.Error(err))
return ctx, nil
}
username, err := GetCurUserFromContext(ctx)

6
pkg/util/funcutil/policy.go
View File

@ -34,17 +34,17 @@ func GetVersion(m proto.GeneratedMessage) (string, error) {
func GetPrivilegeExtObj(m proto.GeneratedMessage) (commonpb.PrivilegeExt, error) {
_, md := descriptor.MessageDescriptorProto(m)
if md == nil {
log.Info("MessageDescriptorProto result is nil")
log.RatedInfo(60, "MessageDescriptorProto result is nil")
return commonpb.PrivilegeExt{}, fmt.Errorf("MessageDescriptorProto result is nil")
}
extObj, err := proto.GetExtension(md.Options, commonpb.E_PrivilegeExtObj)
if err != nil {
log.Info("GetExtension fail", zap.Error(err))
log.RatedInfo(60, "GetExtension fail", zap.Error(err))
return commonpb.PrivilegeExt{}, err
}
privilegeExt := extObj.(*commonpb.PrivilegeExt)
log.Debug("GetPrivilegeExtObj success", zap.String("resource_type", privilegeExt.ObjectType.String()), zap.String("resource_privilege", privilegeExt.ObjectPrivilege.String()))
log.RatedDebug(60, "GetPrivilegeExtObj success", zap.String("resource_type", privilegeExt.ObjectType.String()), zap.String("resource_privilege", privilegeExt.ObjectPrivilege.String()))
return commonpb.PrivilegeExt{
ObjectType: privilegeExt.ObjectType,
ObjectPrivilege: privilegeExt.ObjectPrivilege,