milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix:diskann search crash when search list = 9999999999 (#30185) 

issue: https://github.com/milvus-io/milvus/issues/29020
Json can't not pass a max_int32 value to int32_t, so let knowhere check
value range by itself.
After fix this, pymilvus will report:
pymilvus.exceptions.MilvusException: <MilvusException: (code=65535,
message=fail to search on QueryNode 6: worker(6) query failed: => failed
to search: arithmetic overflow: param search_list_size should be at most
2147483647)>

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
pull/30217/head
cqy123456 2024-01-23 14:46:55 +08:00 committed by GitHub
parent 6cf2f09b60
commit 42bb4e37e5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
internal/core/src/index/VectorDiskIndex.cpp
View File

@ -310,13 +310,11 @@ VectorDiskAnnIndex<T>::Query(const DatasetPtr dataset,
search_config[knowhere::meta::TOPK] = topk;
search_config[knowhere::meta::METRIC_TYPE] = GetMetricType();
// set search list size
auto search_list_size = GetValueFromConfig<uint32_t>(
search_info.search_params_, DISK_ANN_QUERY_LIST);
if (GetIndexType() == knowhere::IndexEnum::INDEX_DISKANN) {
if (search_list_size.has_value()) {
search_config[DISK_ANN_SEARCH_LIST_SIZE] = search_list_size.value();
// set search list size
if (CheckKeyInConfig(search_info.search_params_, DISK_ANN_QUERY_LIST)) {
search_config[DISK_ANN_SEARCH_LIST_SIZE] =
search_info.search_params_[DISK_ANN_QUERY_LIST];
}
// set beamwidth
search_config[DISK_ANN_QUERY_BEAMWIDTH] = int(search_beamwidth_);