milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

enhance: change default partition num to 16 when using partition key (#32950) 

/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
pull/33011/head
SimFG 2024-05-13 14:19:31 +08:00 committed by GitHub
parent 12ec3d61d9
commit 4031abd2fa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
client/collection_options.go
View File

@ -18,6 +18,7 @@ package client
import (
"github.com/golang/protobuf/proto"
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
"github.com/milvus-io/milvus/client/v2/entity"

2
pkg/common/common.go
View File

@ -54,7 +54,7 @@ const (
DefaultShardsNum = int32(1)
// DefaultPartitionsWithPartitionKey defines the default number of partitions when use partition key
DefaultPartitionsWithPartitionKey = int64(64)
DefaultPartitionsWithPartitionKey = int64(16)
// InvalidPartitionID indicates that the partition is not specified. It will be set when the partitionName is empty
InvalidPartitionID = int64(-1)

8
tests/integration/partitionkey/partition_key_test.go
View File

@ -99,7 +99,7 @@ func (s *PartitionKeySuite) TestPartitionKey() {
{
pkColumn := integration.NewInt64FieldDataWithStart(integration.Int64Field, rowNum, rowNum)
fVecColumn := integration.NewFloatVectorFieldData(integration.FloatVecField, rowNum, dim)
partitionKeyColumn := integration.NewInt64SameFieldData("pid", rowNum, 2)
partitionKeyColumn := integration.NewInt64SameFieldData("pid", rowNum, 10)
hashKeys := integration.GenerateHashKeys(rowNum)
insertResult, err := c.Proxy.Insert(ctx, &milvuspb.InsertRequest{
DbName: dbName,
@ -115,7 +115,7 @@ func (s *PartitionKeySuite) TestPartitionKey() {
{
pkColumn := integration.NewInt64FieldDataWithStart(integration.Int64Field, rowNum, rowNum*2)
fVecColumn := integration.NewFloatVectorFieldData(integration.FloatVecField, rowNum, dim)
partitionKeyColumn := integration.NewInt64SameFieldData("pid", rowNum, 3)
partitionKeyColumn := integration.NewInt64SameFieldData("pid", rowNum, 100)
hashKeys := integration.GenerateHashKeys(rowNum)
insertResult, err := c.Proxy.Insert(ctx, &milvuspb.InsertRequest{
DbName: dbName,
@ -216,7 +216,7 @@ func (s *PartitionKeySuite) TestPartitionKey() {
}
{
// search without partition key
// search with partition key
expr := fmt.Sprintf("%s > 0 && pid == 1", integration.Int64Field)
nq := 10
topk := 10
@ -382,7 +382,7 @@ func (s *PartitionKeySuite) TestPartitionKey() {
deleteResult, err := c.Proxy.Delete(ctx, &milvuspb.DeleteRequest{
DbName: dbName,
CollectionName: collectionName,
Expr: integration.Int64Field + " < 2000 && pid == 2",
Expr: integration.Int64Field + " < 2000 && pid == 10",
})
if deleteResult.GetStatus().GetErrorCode() != commonpb.ErrorCode_Success {
log.Warn("deleteResult fail reason", zap.String("reason", deleteResult.GetStatus().GetReason()))

2
tests/python_client/common/common_type.py
View File

@ -17,7 +17,7 @@ max_limit = 16384
max_top_k = 16384
max_partition_num = 4096
max_role_num = 10
default_partition_num = 64 # default num_partitions for partition key feature
default_partition_num = 16 # default num_partitions for partition key feature
default_segment_row_limit = 1000
default_server_segment_row_limit = 1024 * 512
default_alias = "default"