From 3febb5e45a956491cf008083939db3ff6dfdb891 Mon Sep 17 00:00:00 2001 From: Cai Yudong Date: Wed, 29 Mar 2023 14:24:01 +0800 Subject: [PATCH] Remove gpu mode param check (#23074) Signed-off-by: Yudong Cai --- internal/util/indexparamcheck/conf_adapter.go | 20 ++----------------- .../util/indexparamcheck/conf_adapter_test.go | 1 - 2 files changed, 2 insertions(+), 19 deletions(-) diff --git a/internal/util/indexparamcheck/conf_adapter.go b/internal/util/indexparamcheck/conf_adapter.go index 4b58d4bf4f..5a6feb1215 100644 --- a/internal/util/indexparamcheck/conf_adapter.go +++ b/internal/util/indexparamcheck/conf_adapter.go @@ -87,10 +87,6 @@ const ( PQM = "PQM" NTREES = "n_trees" - - IndexMode = "index_mode" - CPUMode = "CPU" - GPUMode = "GPU" ) // METRICS is a set of all metrics types supported for float vector. @@ -177,11 +173,8 @@ func (adapter *IVFPQConfAdapter) checkPQParams(params map[string]string) bool { // nbits can be set to default: 8 nbitsStr, nbitsExist := params[NBITS] - var nbits int - if !nbitsExist { - nbits = 8 - } else { - nbits, err = strconv.Atoi(nbitsStr) + if nbitsExist { + _, err := strconv.Atoi(nbitsStr) if err != nil { // invalid nbits return false } @@ -196,15 +189,6 @@ func (adapter *IVFPQConfAdapter) checkPQParams(params map[string]string) bool { return false } - mode, ok := params[IndexMode] - if !ok { - mode = CPUMode - } - - if mode == GPUMode && !adapter.checkGPUPQParams(dimension, m, nbits) { - return false - } - return adapter.checkCPUPQParams(dimension, m) } diff --git a/internal/util/indexparamcheck/conf_adapter_test.go b/internal/util/indexparamcheck/conf_adapter_test.go index a5d1953478..8e1328eaa3 100644 --- a/internal/util/indexparamcheck/conf_adapter_test.go +++ b/internal/util/indexparamcheck/conf_adapter_test.go @@ -134,7 +134,6 @@ func TestIVFPQConfAdapter_CheckTrain(t *testing.T) { invalidParamsIVF[IVFM] = "NAN" invalidParamsM := copyParams(validParams) - invalidParamsM[IndexMode] = GPUMode invalidParamsM[DIM] = strconv.Itoa(65536) invalidParamsMzero := copyParams(validParams)