MS-608 Update TODO names

Former-commit-id: 6a3cabeef62feb3c3125bc5e9a9b2c4f6eb20d7c
pull/191/head
wxyu 2019-10-07 15:29:56 +08:00
parent 6fe1fb9a11
commit 3ad2b8d74c
11 changed files with 15 additions and 14 deletions

View File

@ -23,6 +23,7 @@ Please mark all change in change log and use the ticket from JIRA.
- MS-574 - Milvus configuration refactor
- MS-578 - Make sure milvus5.0 don't crack 0.3.1 data
- MS-585 - Update namespace in scheduler
- MS-608 - Update TODO names
## New Feature

View File

@ -74,7 +74,7 @@ ResourceMgr::Connect(const std::string& name1, const std::string& name2, Connect
auto res2 = GetResource(name2);
if (res1 && res2) {
res1->AddNeighbour(std::static_pointer_cast<Node>(res2), connection);
// TODO(wxy): enable when task balance supported
// TODO(wxyu): enable when task balance supported
// res2->AddNeighbour(std::static_pointer_cast<Node>(res1), connection);
return true;
}

View File

@ -64,7 +64,7 @@ class ResourceMgr {
return disk_resources_;
}
// TODO(wxy): why return shared pointer
// TODO(wxyu): why return shared pointer
inline std::vector<ResourcePtr>
GetAllResources() {
return resources_;
@ -89,7 +89,7 @@ class ResourceMgr {
GetNumGpuResource() const;
public:
// TODO(wxy): add stats interface(low)
// TODO(wxyu): add stats interface(low)
public:
/******** Utility Functions ********/

View File

@ -146,7 +146,7 @@ load_advance_config() {
// }
// } catch (const char *msg) {
// SERVER_LOG_ERROR << msg;
// // TODO(wxy): throw exception instead
// // TODO(wxyu): throw exception instead
// exit(-1);
//// throw std::exception();
// }

View File

@ -92,7 +92,7 @@ Scheduler::Process(const EventPtr& event) {
process_event(event);
}
// TODO(wxy): refactor the function
// TODO(wxyu): refactor the function
void
Scheduler::OnLoadCompleted(const EventPtr& event) {
auto load_completed_event = std::static_pointer_cast<LoadCompletedEvent>(event);

View File

@ -31,7 +31,7 @@
namespace milvus {
namespace scheduler {
// TODO(wxy): refactor, not friendly to unittest, logical in framework code
// TODO(wxyu): refactor, not friendly to unittest, logical in framework code
class Scheduler {
public:
explicit Scheduler(ResourceMgrWPtr res_mgr);

View File

@ -32,7 +32,7 @@ TaskCreator::Create(const JobPtr& job) {
return Create(std::static_pointer_cast<DeleteJob>(job));
}
default: {
// TODO(wxy): error
// TODO(wxyu): error
return std::vector<TaskPtr>();
}
}

View File

@ -125,7 +125,7 @@ class TaskTable {
Get(uint64_t index);
/*
* TODO(wxy): BIG GC
* TODO(wxyu): BIG GC
* Remove sequence task which is DONE or MOVED from front;
* Called by ?
*/
@ -173,7 +173,7 @@ class TaskTable {
public:
/******** Action ********/
// TODO(wxy): bool to Status
// TODO(wxyu): bool to Status
/*
* Load a task;
* Set state loading;

View File

@ -82,7 +82,7 @@ Action::PushTaskToNeighbourRandomly(const TaskPtr& task, const ResourcePtr& self
}
} else {
// TODO(wxy): process
// TODO(wxyu): process
}
}

View File

@ -38,7 +38,7 @@
namespace milvus {
namespace scheduler {
// TODO(wxy): Storage, Route, Executor
// TODO(wxyu): Storage, Route, Executor
enum class ResourceType {
DISK = 0,
CPU = 1,
@ -114,11 +114,11 @@ class Resource : public Node, public std::enable_shared_from_this<Resource> {
return enable_executor_;
}
// TODO(wxy): const
// TODO(wxyu): const
uint64_t
NumOfTaskToExec();
// TODO(wxy): need double ?
// TODO(wxyu): need double ?
inline uint64_t
TaskAvgCost() const {
return total_cost_ / total_task_;

View File

@ -26,7 +26,7 @@
namespace milvus {
namespace scheduler {
// TODO(wxy): rewrite
// TODO(wxyu): rewrite
class XSearchTask : public Task {
public:
explicit XSearchTask(TableFileSchemaPtr file);