From 38e5e33196eecbf06094b1537d977cd696e3da17 Mon Sep 17 00:00:00 2001 From: Buqian Zheng Date: Fri, 31 May 2024 10:17:50 +0800 Subject: [PATCH] enhance: [2.4] update knowhere version (#33491) issue: https://github.com/milvus-io/milvus/issues/33489 pr: #33490 update knowhere version to latest. remove usage of seed_ef as it be replaced by existing ef. Signed-off-by: Buqian Zheng --- internal/core/src/query/GroupByOperator.h | 4 ---- internal/core/thirdparty/knowhere/CMakeLists.txt | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/internal/core/src/query/GroupByOperator.h b/internal/core/src/query/GroupByOperator.h index 64e1122537..21162c09bf 100644 --- a/internal/core/src/query/GroupByOperator.h +++ b/internal/core/src/query/GroupByOperator.h @@ -133,10 +133,6 @@ PrepareVectorIteratorsFromIndex(const SearchInfo& search_info, if (search_info.group_by_field_id_.has_value()) { try { auto search_conf = search_info.search_params_; - if (search_conf.contains(knowhere::indexparam::EF)) { - search_conf[knowhere::indexparam::SEED_EF] = - search_conf[knowhere::indexparam::EF]; - } knowhere::expected< std::vector>> iterators_val = diff --git a/internal/core/thirdparty/knowhere/CMakeLists.txt b/internal/core/thirdparty/knowhere/CMakeLists.txt index 0e9132ee50..3c5a4b5a9e 100644 --- a/internal/core/thirdparty/knowhere/CMakeLists.txt +++ b/internal/core/thirdparty/knowhere/CMakeLists.txt @@ -12,7 +12,7 @@ #------------------------------------------------------------------------------- # Update KNOWHERE_VERSION for the first occurrence -set( KNOWHERE_VERSION v2.3.3 ) +set( KNOWHERE_VERSION v2.3.4 ) set( GIT_REPOSITORY "https://github.com/zilliztech/knowhere.git") message(STATUS "Knowhere repo: ${GIT_REPOSITORY}") message(STATUS "Knowhere version: ${KNOWHERE_VERSION}")