milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix MQ Factory timeout unit test (#28395) 

This PR change timeout case to a longer duration in case of slow runner
Also change timeout case behavior of using timeout deadline instead of waiting
See also #28394

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
pull/28402/head
congqixia 2023-11-13 21:44:18 +08:00 committed by GitHub
parent cfb6edea61
commit 371875f650
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
pkg/mq/msgstream/mq_factory_test.go
View File

@ -46,12 +46,12 @@ func TestPmsFactory(t *testing.T) {
var cancel context.CancelFunc
ctx := context.Background()
if test.withTimeout {
ctx, cancel = context.WithTimeout(ctx, time.Millisecond)
defer cancel()
}
if test.ctxTimeouted {
time.Sleep(time.Millisecond)
ctx, cancel = context.WithDeadline(ctx, time.Now().Add(-1*time.Minute))
} else {
ctx, cancel = context.WithTimeout(ctx, time.Second*10)
}
defer cancel()
}
stream, err := pmsFactory.NewMsgStream(ctx)
if test.expectedError {
@ -120,14 +120,13 @@ func TestKafkaFactory(t *testing.T) {
t.Run(test.description, func(t *testing.T) {
var cancel context.CancelFunc
ctx := context.Background()
timeoutDur := time.Millisecond * 30
if test.withTimeout {
ctx, cancel = context.WithTimeout(ctx, timeoutDur)
defer cancel()
}
if test.ctxTimeouted {
time.Sleep(timeoutDur)
ctx, cancel = context.WithDeadline(ctx, time.Now().Add(-1*time.Minute))
} else {
ctx, cancel = context.WithTimeout(ctx, time.Second*10)
}
defer cancel()
}
stream, err := kmsFactory.NewMsgStream(ctx)
if test.expectedError {