milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix NodeID rw race (#22945) 

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
pull/22938/head
congqixia 2023-03-23 11:45:57 +08:00 committed by GitHub
parent 9ded71f2bb
commit 31c22e5d24
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
internal/util/grpcclient/client.go
View File

@ -24,6 +24,7 @@ import (
"time" "time"
"go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc" "go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc"
"go.uber.org/atomic"
"go.uber.org/zap" "go.uber.org/zap"
"golang.org/x/sync/singleflight" "golang.org/x/sync/singleflight"
"google.golang.org/grpc" "google.golang.org/grpc"
@ -83,7 +84,7 @@ type ClientBase[T interface {
InitialBackoff float32 InitialBackoff float32
MaxBackoff float32 MaxBackoff float32
BackoffMultiplier float32 BackoffMultiplier float32
NodeID int64 NodeID atomic.Int64
sf singleflight.Group sf singleflight.Group
} }
@ -357,10 +358,10 @@ func (c *ClientBase[T]) Close() error {
// SetNodeID set ID role of client // SetNodeID set ID role of client
func (c *ClientBase[T]) SetNodeID(nodeID int64) { func (c *ClientBase[T]) SetNodeID(nodeID int64) {
c.NodeID = nodeID c.NodeID.Store(nodeID)
} }
// GetNodeID returns ID of client // GetNodeID returns ID of client
func (c *ClientBase[T]) GetNodeID() int64 { func (c *ClientBase[T]) GetNodeID() int64 {
return c.NodeID return c.NodeID.Load()
} }