milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve the panic code about the milvus component #24783 (#24919) 

Signed-off-by: SimFG <bang.fu@zilliz.com>
pull/24963/head
SimFG 2023-06-17 10:32:39 +08:00 committed by GitHub
parent cc0154d120
commit 31c08a8135
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 20 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/components/data_coord.go
View File

@ -25,6 +25,7 @@ import (
"github.com/milvus-io/milvus/internal/util/dependency"
"github.com/milvus-io/milvus/pkg/log"
"github.com/milvus-io/milvus/pkg/util/typeutil"
"go.uber.org/zap"
)
// DataCoord implements grpc server of DataCoord server
@ -46,6 +47,7 @@ func NewDataCoord(ctx context.Context, factory dependency.Factory) (*DataCoord,
// Run starts service
func (s *DataCoord) Run() error {
if err := s.svr.Run(); err != nil {
log.Error("DataCoord starts error", zap.Error(err))
return err
}
log.Debug("DataCoord successfully started")

4
cmd/components/data_node.go
View File

@ -25,6 +25,7 @@ import (
"github.com/milvus-io/milvus/internal/util/dependency"
"github.com/milvus-io/milvus/pkg/log"
"github.com/milvus-io/milvus/pkg/util/typeutil"
"go.uber.org/zap"
)
// DataNode implements DataNode grpc server
@ -49,7 +50,8 @@ func NewDataNode(ctx context.Context, factory dependency.Factory) (*DataNode, er
// Run starts service
func (d *DataNode) Run() error {
if err := d.svr.Run(); err != nil {
panic(err)
log.Error("DataNode starts error", zap.Error(err))
return err
}
log.Debug("Datanode successfully started")
return nil

2
cmd/components/index_node.go
View File

@ -25,6 +25,7 @@ import (
"github.com/milvus-io/milvus/internal/util/dependency"
"github.com/milvus-io/milvus/pkg/log"
"github.com/milvus-io/milvus/pkg/util/typeutil"
"go.uber.org/zap"
)
// IndexNode implements IndexNode grpc server
@ -48,6 +49,7 @@ func NewIndexNode(ctx context.Context, factory dependency.Factory) (*IndexNode,
// Run starts service
func (n *IndexNode) Run() error {
if err := n.svr.Run(); err != nil {
log.Error("IndexNode starts error", zap.Error(err))
return err
}
log.Debug("IndexNode successfully started")

5
cmd/components/proxy.go
View File

@ -19,14 +19,13 @@ package components
import (
"context"
"go.uber.org/zap"
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
grpcproxy "github.com/milvus-io/milvus/internal/distributed/proxy"
"github.com/milvus-io/milvus/internal/util/dependency"
"github.com/milvus-io/milvus/pkg/log"
"github.com/milvus-io/milvus/pkg/util/typeutil"
"go.uber.org/zap"
)
// Proxy implements Proxy grpc server
@ -50,7 +49,7 @@ func NewProxy(ctx context.Context, factory dependency.Factory) (*Proxy, error) {
// Run starts service
func (n *Proxy) Run() error {
if err := n.svr.Run(); err != nil {
log.Warn("failed to start Proxy", zap.Error(err))
log.Error("Proxy starts error", zap.Error(err))
return err
}
log.Info("Proxy successfully started")

11
cmd/components/query_coord.go
View File

@ -19,14 +19,14 @@ package components
import (
"context"
"go.uber.org/zap"
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
grpcquerycoord "github.com/milvus-io/milvus/internal/distributed/querycoord"
"github.com/milvus-io/milvus/internal/util/dependency"
"github.com/milvus-io/milvus/pkg/log"
"github.com/milvus-io/milvus/pkg/util/typeutil"
grpcquerycoord "github.com/milvus-io/milvus/internal/distributed/querycoord"
)
// QueryCoord implements QueryCoord grpc server
@ -39,7 +39,7 @@ type QueryCoord struct {
func NewQueryCoord(ctx context.Context, factory dependency.Factory) (*QueryCoord, error) {
svr, err := grpcquerycoord.NewServer(ctx, factory)
if err != nil {
panic(err)
return nil, err
}
return &QueryCoord{
@ -51,7 +51,8 @@ func NewQueryCoord(ctx context.Context, factory dependency.Factory) (*QueryCoord
// Run starts service
func (qs *QueryCoord) Run() error {
if err := qs.svr.Run(); err != nil {
panic(err)
log.Error("QueryCoord starts error", zap.Error(err))
return err
}
log.Debug("QueryCoord successfully started")
return nil

9
cmd/components/query_node.go
View File

@ -19,14 +19,14 @@ package components
import (
"context"
"go.uber.org/zap"
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
grpcquerynode "github.com/milvus-io/milvus/internal/distributed/querynode"
"github.com/milvus-io/milvus/internal/util/dependency"
"github.com/milvus-io/milvus/pkg/log"
"github.com/milvus-io/milvus/pkg/util/typeutil"
grpcquerynode "github.com/milvus-io/milvus/internal/distributed/querynode"
)
// QueryNode implements QueryNode grpc server
@ -52,7 +52,8 @@ func NewQueryNode(ctx context.Context, factory dependency.Factory) (*QueryNode,
// Run starts service
func (q *QueryNode) Run() error {
if err := q.svr.Run(); err != nil {
panic(err)
log.Error("QueryNode starts error", zap.Error(err))
return err
}
log.Debug("QueryNode successfully started")
return nil

1
cmd/components/root_coord.go
View File

@ -25,7 +25,6 @@ import (
"github.com/milvus-io/milvus/internal/util/dependency"
"github.com/milvus-io/milvus/pkg/log"
"github.com/milvus-io/milvus/pkg/util/typeutil"
"go.uber.org/zap"
)