milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

enhance: Refine clustering compaction log (#38100) 

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
pull/38140/head
cai.zhang 2024-12-03 14:58:39 +08:00 committed by GitHub
parent 9e008685ef
commit 28d39399e2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/datacoord/compaction_task_clustering.go
View File

@ -247,6 +247,7 @@ func (t *clusteringCompactionTask) processExecuting() error {
log := log.With(zap.Int64("planID", t.GetTaskProto().GetPlanID()), zap.String("type", t.GetTaskProto().GetType().String()))
result, err := t.sessions.GetCompactionPlanResult(t.GetTaskProto().GetNodeID(), t.GetTaskProto().GetPlanID())
if err != nil || result == nil {
log.Warn("processExecuting clustering compaction", zap.Error(err))
if errors.Is(err, merr.ErrNodeNotFound) {
log.Warn("GetCompactionPlanResult fail", zap.Error(err))
// setNodeID(NullNodeID) to trigger reassign node ID
@ -254,7 +255,8 @@ func (t *clusteringCompactionTask) processExecuting() error {
}
return err
}
log.Info("compaction result", zap.Any("result", result.String()))
log.Debug("compaction result", zap.String("result state", result.GetState().String()),
zap.Int("result segments num", len(result.GetSegments())), zap.Int("result string length", len(result.String())))
switch result.GetState() {
case datapb.CompactionTaskState_completed:
t.result = result
@ -685,6 +687,7 @@ func (t *clusteringCompactionTask) updateAndSaveTaskMeta(opts ...compactionTaskO
return merr.WrapErrClusteringCompactionMetaError("updateAndSaveTaskMeta", err) // retryable
}
t.SetTask(task)
log.Info("updateAndSaveTaskMeta success", zap.String("task state", t.GetTaskProto().GetState().String()))
return nil
}