milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove delete log in datanode because it may influence datanode performance (#17415) 

Resolves #16984

Signed-off-by: wayblink <anyang.wang@zilliz.com>
pull/17458/head
wayblink 2022-06-08 19:10:07 +08:00 committed by GitHub
parent dbef4c6ec2
commit 25883840b2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
internal/datanode/flow_graph_delete_node.go
View File

@ -148,11 +148,13 @@ func (dn *deleteNode) bufferDeleteMsg(msg *msgstream.DeleteMsg, tr TimeRange) er
for i := 0; i < rows; i++ {
delData.Pks = append(delData.Pks, pks[i])
delData.Tss = append(delData.Tss, tss[i])
log.Debug("delete",
zap.Any("primary key", pks[i]),
zap.Uint64("ts", tss[i]),
zap.Int64("segmentID", segID),
zap.String("vChannelName", dn.channelName))
// this log will influence the data node performance as it may be too many,
// only use it when we focus on delete operations
//log.Debug("delete",
// zap.Any("primary key", pks[i]),
// zap.Uint64("ts", tss[i]),
// zap.Int64("segmentID", segID),
// zap.String("vChannelName", dn.channelName))
}
// store
@ -178,12 +180,14 @@ func (dn *deleteNode) showDelBuf() {
// TODO control the printed length
length := len(delDataBuf.delData.Pks)
for i := 0; i < length; i++ {
log.Debug("del data",
zap.Any("pk", delDataBuf.delData.Pks[i]),
zap.Uint64("ts", delDataBuf.delData.Tss[i]),
zap.Int64("segment ID", segID),
zap.String("vChannel", dn.channelName),
)
// this log will influence the data node performance as it may be too many,
// only use it when we focus on delete operations
//log.Debug("del data",
// zap.Any("pk", delDataBuf.delData.Pks[i]),
// zap.Uint64("ts", delDataBuf.delData.Tss[i]),
// zap.Int64("segment ID", segID),
// zap.String("vChannel", dn.channelName),
//)
}
} else {
log.Debug("segment not exist",