milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

enhance: Print `UseDefaultConsistency` param in read requests (#33617) 

`UseDefaultConsistency` param is crucial for debugging slow query
problems. It could be confusing when guarantee timestamp is 1 while this
param is not logged

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
pull/33596/head^2
congqixia 2024-06-05 10:27:50 +08:00 committed by GitHub
parent 516f39b616
commit 25080bb455
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
internal/proxy/impl.go
View File

@ -2968,6 +2968,7 @@ func (node *Proxy) search(ctx context.Context, request *milvuspb.SearchRequest)
zap.Any("OutputFields", request.OutputFields),
zap.Any("search_params", request.SearchParams),
zap.Uint64("guarantee_timestamp", guaranteeTs),
zap.Bool("useDefaultConsistency", request.GetUseDefaultConsistency()),
)
defer func() {
@ -3167,6 +3168,7 @@ func (node *Proxy) hybridSearch(ctx context.Context, request *milvuspb.HybridSea
zap.Any("partitions", request.PartitionNames),
zap.Any("OutputFields", request.OutputFields),
zap.Uint64("guarantee_timestamp", guaranteeTs),
zap.Bool("useDefaultConsistency", request.GetUseDefaultConsistency()),
)
defer func() {
@ -3429,6 +3431,7 @@ func (node *Proxy) query(ctx context.Context, qt *queryTask) (*milvuspb.QueryRes
zap.String("db", request.DbName),
zap.String("collection", request.CollectionName),
zap.Strings("partitions", request.PartitionNames),
zap.Bool("useDefaultConsistency", request.GetUseDefaultConsistency()),
)
log.Debug(