milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix config wal valid_recovery_error_ignore bug 

Signed-off-by: Yhz <yinghao.zou@zilliz.com>
pull/1566/head
Yhz 2020-03-08 14:30:02 +08:00
parent 0fcdc31c7c
commit 24daade18e
3 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -42,6 +42,7 @@ Please mark all change in change log and use the issue from GitHub
- \#1529 Fix server crash when cache_insert_data enabled - \#1529 Fix server crash when cache_insert_data enabled
- \#1530 Set table file with correct engine type in meta - \#1530 Set table file with correct engine type in meta
- \#1535 Degradation searching performance with metric_type: binary_idmap - \#1535 Degradation searching performance with metric_type: binary_idmap
- \#1549 Fix server/wal config setting bug
## Feature ## Feature
- \#216 Add CLI to get server info - \#216 Add CLI to get server info

2
core/src/server/Config.cpp
View File

@ -2013,7 +2013,7 @@ Config::SetWalConfigEnable(const std::string& value) {
Status Status
Config::SetWalConfigRecoveryErrorIgnore(const std::string& value) { Config::SetWalConfigRecoveryErrorIgnore(const std::string& value) {
CONFIG_CHECK(CheckWalConfigRecoveryErrorIgnore(value)); CONFIG_CHECK(CheckWalConfigRecoveryErrorIgnore(value));
return SetConfigValueInMem(CONFIG_WAL, CONFIG_WAL_RECOVERY_ERROR_IGNORE_DEFAULT, value); return SetConfigValueInMem(CONFIG_WAL, CONFIG_WAL_RECOVERY_ERROR_IGNORE, value);
} }
Status Status

3
core/src/server/Config.h
View File

@ -191,6 +191,9 @@ class Config {
Status Status
SetConfigCli(const std::string& parent_key, const std::string& child_key, const std::string& value); SetConfigCli(const std::string& parent_key, const std::string& child_key, const std::string& value);
Status
CheckDuplicatePort();
Status Status
UpdateFileConfigFromMem(const std::string& parent_key, const std::string& child_key); UpdateFileConfigFromMem(const std::string& parent_key, const std::string& child_key);