From 2256b53e0324b771bf36056854590c6472500955 Mon Sep 17 00:00:00 2001 From: aoiasd <45024769+aoiasd@users.noreply.github.com> Date: Mon, 25 Dec 2023 10:16:53 +0800 Subject: [PATCH] fix: [Cherry-pick]Remove SetFinalizer which cause proxy msgstream memory leak (#29404) relate: https://github.com/milvus-io/milvus/issues/28367 pr: https://github.com/milvus-io/milvus/pull/29403 Signed-off-by: aoiasd --- internal/proxy/channels_mgr.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/internal/proxy/channels_mgr.go b/internal/proxy/channels_mgr.go index 3ecdce564c..28e56ebabe 100644 --- a/internal/proxy/channels_mgr.go +++ b/internal/proxy/channels_mgr.go @@ -19,7 +19,6 @@ package proxy import ( "context" "fmt" - "runtime" "strconv" "sync" @@ -187,10 +186,6 @@ func createStream(factory msgstream.Factory, pchans []pChan, repack repackFuncTy if repack != nil { stream.SetRepackFunc(repack) } - runtime.SetFinalizer(stream, func(stream msgstream.MsgStream) { - stream.Close() - }) - return stream, nil }