milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix some unreasonable logs in Proxy (#20411) 

Signed-off-by: longjiquan <jiquan.long@zilliz.com>

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
pull/20431/head
Jiquan Long 2022-11-09 15:05:08 +08:00 committed by GitHub
parent 39a6397043
commit 2189530f5b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/proxy/segment.go
View File

@ -327,7 +327,7 @@ func (sa *segIDAssigner) syncSegments() (bool, error) {
success := true
for _, segAssign := range resp.SegIDAssignments {
if segAssign.Status.GetErrorCode() != commonpb.ErrorCode_Success {
log.Debug("proxy", zap.String("SyncSegment Error", segAssign.Status.Reason))
log.Warn("proxy", zap.String("SyncSegment Error", segAssign.Status.Reason))
errMsg += segAssign.Status.Reason
errMsg += "\n"
success = false

2
internal/proxy/task_insert.go
View File

@ -450,7 +450,7 @@ func (it *insertTask) Execute(ctx context.Context) error {
return err
}
log.Info("send insert request to virtual channels",
log.Ctx(ctx).Debug("send insert request to virtual channels",
zap.String("collection", it.GetCollectionName()),
zap.String("partition", it.GetPartitionName()),
zap.Int64("collection_id", collID),

8
internal/proxy/task_scheduler.go
View File

@ -123,7 +123,7 @@ func (queue *baseTaskQueue) AddActiveTask(t task) {
tID := t.ID()
_, ok := queue.activeTasks[tID]
if ok {
log.Debug("Proxy task with tID already in active task list!", zap.Any("ID", tID))
log.Warn("Proxy task with tID already in active task list!", zap.Int64("ID", tID))
}
queue.activeTasks[tID] = t
@ -138,7 +138,7 @@ func (queue *baseTaskQueue) PopActiveTask(taskID UniqueID) task {
return t
}
log.Debug("Proxy task not in active task list! ts", zap.Any("taskID", taskID))
log.Warn("Proxy task not in active task list! ts", zap.Int64("taskID", taskID))
return t
}
@ -252,7 +252,7 @@ func (queue *dmTaskQueue) PopActiveTask(taskID UniqueID) task {
log.Debug("Proxy dmTaskQueue popPChanStats", zap.Any("taskID", t.ID()))
queue.popPChanStats(t)
} else {
log.Debug("Proxy task not in active task list!", zap.Any("taskID", taskID))
log.Warn("Proxy task not in active task list!", zap.Any("taskID", taskID))
}
return t
}
@ -261,7 +261,7 @@ func (queue *dmTaskQueue) addPChanStats(t task) error {
if dmT, ok := t.(dmlTask); ok {
stats, err := dmT.getPChanStats()
if err != nil {
log.Debug("Proxy dmTaskQueue addPChanStats", zap.Any("tID", t.ID()),
log.Warn("Proxy dmTaskQueue addPChanStats", zap.Any("tID", t.ID()),
zap.Any("stats", stats), zap.Error(err))
return err
}

2
internal/proxy/task_search.go
View File

@ -534,7 +534,7 @@ func (t *searchTask) fillInFieldInfo() {
func (t *searchTask) collectSearchResults(ctx context.Context) error {
select {
case <-t.TraceCtx().Done():
log.Ctx(ctx).Debug("wait to finish timeout!", zap.Int64("msgID", t.ID()))
log.Ctx(ctx).Warn("search task wait to finish timeout!", zap.Int64("msgID", t.ID()))
return fmt.Errorf("search task wait to finish timeout, msgID=%d", t.ID())
default:
log.Ctx(ctx).Debug("all searches are finished or canceled", zap.Int64("msgID", t.ID()))