From 1ac30913e73d9eb621eb770a7dd0125fd5c2c6a8 Mon Sep 17 00:00:00 2001
From: "xiaojun.lin" <xiaojun.lin@zilliz.com>
Date: Thu, 21 Nov 2019 15:06:00 +0800
Subject: [PATCH] move seal to Load

---
 CHANGELOG.md                                                  | 1 +
 .../knowhere/knowhere/index/vector_index/FaissBaseIndex.cpp   | 4 +++-
 .../knowhere/knowhere/index/vector_index/IndexGPUIVF.cpp      | 3 ---
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index a8b243546e..af4abe71a5 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -18,6 +18,7 @@ Please mark all change in change log and use the ticket from JIRA.
 - \#412 - Message returned is confused when partition created with null partition name
 - \#416 - Drop the same partition success repeatally
 - \#440 - Query API in customization still uses old version
+- \#458 - Index data is not compatible between 0.5 and 0.6
 
 ## Feature
 - \#12 - Pure CPU version for Milvus
diff --git a/core/src/index/knowhere/knowhere/index/vector_index/FaissBaseIndex.cpp b/core/src/index/knowhere/knowhere/index/vector_index/FaissBaseIndex.cpp
index 783487be3a..8fce37a81e 100644
--- a/core/src/index/knowhere/knowhere/index/vector_index/FaissBaseIndex.cpp
+++ b/core/src/index/knowhere/knowhere/index/vector_index/FaissBaseIndex.cpp
@@ -33,7 +33,7 @@ FaissBaseIndex::SerializeImpl() {
     try {
         faiss::Index* index = index_.get();
 
-        SealImpl();
+        // SealImpl();
 
         MemoryIOWriter writer;
         faiss::write_index(index, &writer);
@@ -60,6 +60,8 @@ FaissBaseIndex::LoadImpl(const BinarySet& index_binary) {
     faiss::Index* index = faiss::read_index(&reader);
 
     index_.reset(index);
+
+    SealImpl();
 }
 
 void
diff --git a/core/src/index/knowhere/knowhere/index/vector_index/IndexGPUIVF.cpp b/core/src/index/knowhere/knowhere/index/vector_index/IndexGPUIVF.cpp
index 251dfc12ed..d69f87a061 100644
--- a/core/src/index/knowhere/knowhere/index/vector_index/IndexGPUIVF.cpp
+++ b/core/src/index/knowhere/knowhere/index/vector_index/IndexGPUIVF.cpp
@@ -86,9 +86,6 @@ GPUIVF::SerializeImpl() {
             faiss::Index* index = index_.get();
             faiss::Index* host_index = faiss::gpu::index_gpu_to_cpu(index);
 
-            // TODO(linxj): support seal
-            // SealImpl();
-
             faiss::write_index(host_index, &writer);
             delete host_index;
         }