milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add log to analysis when etcd txn operation failed (#21559) 

Signed-off-by: wayblink <anyang.wang@zilliz.com>
pull/21941/head
wayblink 2023-02-02 15:53:52 +08:00 committed by GitHub
parent 85dd8912eb
commit 161725a661
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 44 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
internal/kv/etcd/etcd_kv.go
View File

@ -434,6 +434,9 @@ func (kv *EtcdKV) MultiSave(kvs map[string]string) error {
CheckTxnStringValueSizeAndWarn(kvs)
_, err := kv.client.Txn(ctx).If().Then(ops...).Commit()
if err != nil {
log.Warn("Etcd MultiSave error", zap.Any("kvs", kvs), zap.Int("len", len(kvs)), zap.Error(err))
}
CheckElapseAndWarn(start, "Slow etcd operation multi save", zap.Strings("keys", keys))
return err
}
@ -453,6 +456,9 @@ func (kv *EtcdKV) MultiSaveBytes(kvs map[string][]byte) error {
CheckTxnBytesValueSizeAndWarn(kvs)
_, err := kv.client.Txn(ctx).If().Then(ops...).Commit()
if err != nil {
log.Warn("Etcd MultiSaveBytes err", zap.Any("kvs", kvs), zap.Int("len", len(kvs)), zap.Error(err))
}
CheckElapseAndWarn(start, "Slow etcd operation multi save", zap.Strings("keys", keys))
return err
}
@ -493,6 +499,9 @@ func (kv *EtcdKV) MultiRemove(keys []string) error {
defer cancel()
_, err := kv.client.Txn(ctx).If().Then(ops...).Commit()
if err != nil {
log.Warn("Etcd MultiRemove error", zap.Strings("keys", keys), zap.Int("len", len(keys)), zap.Error(err))
}
CheckElapseAndWarn(start, "Slow etcd operation multi remove", zap.Strings("keys", keys))
return err
}
@ -515,6 +524,14 @@ func (kv *EtcdKV) MultiSaveAndRemove(saves map[string]string, removals []string)
defer cancel()
_, err := kv.client.Txn(ctx).If().Then(ops...).Commit()
if err != nil {
log.Warn("Etcd MultiSaveAndRemove error",
zap.Any("saves", saves),
zap.Strings("removes", removals),
zap.Int("saveLength", len(saves)),
zap.Int("removeLength", len(removals)),
zap.Error(err))
}
CheckElapseAndWarn(start, "Slow etcd operation multi save and remove", zap.Strings("keys", keys))
return err
}
@ -537,6 +554,14 @@ func (kv *EtcdKV) MultiSaveBytesAndRemove(saves map[string][]byte, removals []st
defer cancel()
_, err := kv.client.Txn(ctx).If().Then(ops...).Commit()
if err != nil {
log.Warn("Etcd MultiSaveBytesAndRemove error",
zap.Any("saves", saves),
zap.Strings("removes", removals),
zap.Int("saveLength", len(saves)),
zap.Int("removeLength", len(removals)),
zap.Error(err))
}
CheckElapseAndWarn(start, "Slow etcd operation multi save and remove", zap.Strings("keys", keys))
return err
}
@ -581,6 +606,9 @@ func (kv *EtcdKV) MultiRemoveWithPrefix(keys []string) error {
defer cancel()
_, err := kv.client.Txn(ctx).If().Then(ops...).Commit()
if err != nil {
log.Warn("Etcd MultiRemoveWithPrefix error", zap.Strings("keys", keys), zap.Int("len", len(keys)), zap.Error(err))
}
CheckElapseAndWarn(start, "Slow etcd operation multi remove with prefix", zap.Strings("keys", keys))
return err
}
@ -603,6 +631,14 @@ func (kv *EtcdKV) MultiSaveAndRemoveWithPrefix(saves map[string]string, removals
defer cancel()
_, err := kv.client.Txn(ctx).If().Then(ops...).Commit()
if err != nil {
log.Warn("Etcd MultiSaveAndRemoveWithPrefix error",
zap.Any("saves", saves),
zap.Strings("removes", removals),
zap.Int("saveLength", len(saves)),
zap.Int("removeLength", len(removals)),
zap.Error(err))
}
CheckElapseAndWarn(start, "Slow etcd operation multi save and move with prefix", zap.Strings("keys", keys))
return err
}
@ -625,6 +661,14 @@ func (kv *EtcdKV) MultiSaveBytesAndRemoveWithPrefix(saves map[string][]byte, rem
defer cancel()
_, err := kv.client.Txn(ctx).If().Then(ops...).Commit()
if err != nil {
log.Warn("Etcd MultiSaveBytesAndRemoveWithPrefix error",
zap.Any("saves", saves),
zap.Strings("removes", removals),
zap.Int("saveLength", len(saves)),
zap.Int("removeLength", len(removals)),
zap.Error(err))
}
CheckElapseAndWarn(start, "Slow etcd operation multi save and move with prefix", zap.Strings("keys", keys))
return err
}