milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Fix no L0 compaction tasks are executed (#34537) 

The nodeID for compaction task initialization is 0. This PR adjusts the
task reassignment conditions to allow new compaction tasks to be
reassigned and executed.

issue: https://github.com/milvus-io/milvus/issues/34460

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
pull/34690/head
yihao.dai 2024-07-15 17:01:37 +08:00 committed by GitHub
parent 8b5754f7fe
commit 1495b7a2c9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/datacoord/compaction_task_clustering.go
View File

@ -558,7 +558,7 @@ func (t *clusteringCompactionTask) GetLabel() string {
}
func (t *clusteringCompactionTask) NeedReAssignNodeID() bool {
return t.GetState() == datapb.CompactionTaskState_pipelining && t.GetNodeID() == 0
return t.GetState() == datapb.CompactionTaskState_pipelining && (t.GetNodeID() == 0 || t.GetNodeID() == NullNodeID)
}
func (t *clusteringCompactionTask) CleanLogPath() {

2
internal/datacoord/compaction_task_l0.go
View File

@ -200,7 +200,7 @@ func (t *l0CompactionTask) SetStartTime(startTime int64) {
}
func (t *l0CompactionTask) NeedReAssignNodeID() bool {
return t.GetState() == datapb.CompactionTaskState_pipelining && t.GetNodeID() == NullNodeID
return t.GetState() == datapb.CompactionTaskState_pipelining && (t.GetNodeID() == 0 || t.GetNodeID() == NullNodeID)
}
func (t *l0CompactionTask) SetResult(result *datapb.CompactionPlanResult) {

2
internal/datacoord/compaction_task_mix.go
View File

@ -169,7 +169,7 @@ func (t *mixCompactionTask) GetLabel() string {
}
func (t *mixCompactionTask) NeedReAssignNodeID() bool {
return t.GetState() == datapb.CompactionTaskState_pipelining && t.GetNodeID() == NullNodeID
return t.GetState() == datapb.CompactionTaskState_pipelining && (t.GetNodeID() == 0 || t.GetNodeID() == NullNodeID)
}
func (t *mixCompactionTask) processCompleted() bool {