milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix pq params check when creating index (#6052) 

Signed-off-by: dragondriver <jiquan.long@zilliz.com>
pull/6071/head
dragondriver 2021-06-24 15:40:10 +08:00 committed by GitHub
parent 064f8f76cd
commit 133814be8e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
internal/util/indexparamcheck/conf_adapter.go
View File

@ -139,24 +139,38 @@ func (adapter *IVFPQConfAdapter) CheckTrain(params map[string]string) bool {
return false
}
// nbits can be set to default: 8
_, nbitsExist := params[NBITS]
if nbitsExist && !CheckIntByRange(params, NBITS, MinNBits, MaxNBits) {
return false
}
return adapter.checkPQParams(params)
}
func (adapter *IVFPQConfAdapter) checkPQParams(params map[string]string) bool {
dimension, _ := strconv.Atoi(params[DIM])
nbits, _ := strconv.Atoi(params[NBITS])
dimStr, dimensionExist := params[DIM]
if !dimensionExist { // dimension is specified when creating collection
return true
}
dimension, err := strconv.Atoi(dimStr)
if err != nil { // invalid dimension
return false
}
// nbits can be set to default: 8
nbitsStr, nbitsExist := params[NBITS]
var nbits int
if !nbitsExist {
nbits = 8
} else {
nbits, err = strconv.Atoi(nbitsStr)
if err != nil { // invalid nbits
return false
}
}
mStr, ok := params[IVFM]
if !ok {
return false
}
m, err := strconv.Atoi(mStr)
if err != nil {
if err != nil { // invalid m
return false
}