milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Disable knowhere trace as a quick fix (#31055) 

Issue: #30961

Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
pull/31144/head
Cai Yudong 2024-03-08 15:27:01 +08:00 committed by GitHub
parent a1db0fc406
commit 122981aeb9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 20 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
internal/core/src/index/VectorIndex.h
View File

@ -120,15 +120,16 @@ class VectorIndex : public IndexBase {
search_cfg[knowhere::meta::TOPK] = search_info.topk_;
// save trace context into search conf
if (search_info.trace_ctx_.traceID != nullptr &&
search_info.trace_ctx_.spanID != nullptr) {
search_cfg[knowhere::meta::TRACE_ID] =
tracer::GetTraceIDAsStr(&search_info.trace_ctx_);
search_cfg[knowhere::meta::SPAN_ID] =
tracer::GetSpanIDAsStr(&search_info.trace_ctx_);
search_cfg[knowhere::meta::TRACE_FLAGS] =
search_info.trace_ctx_.traceFlags;
}
// TODO caiyd: will enable this after adding switch for trace
// if (search_info.trace_ctx_.traceID != nullptr &&
// search_info.trace_ctx_.spanID != nullptr) {
// search_cfg[knowhere::meta::TRACE_ID] =
// tracer::GetTraceIDAsStr(&search_info.trace_ctx_);
// search_cfg[knowhere::meta::SPAN_ID] =
// tracer::GetSpanIDAsStr(&search_info.trace_ctx_);
// search_cfg[knowhere::meta::TRACE_FLAGS] =
// search_info.trace_ctx_.traceFlags;
// }
return search_cfg;
}

19
internal/core/src/query/SearchBruteForce.cpp
View File

@ -50,15 +50,16 @@ PrepareBFSearchParams(const SearchInfo& search_info) {
search_cfg[knowhere::meta::TOPK] = search_info.topk_;
// save trace context into search conf
if (search_info.trace_ctx_.traceID != nullptr &&
search_info.trace_ctx_.spanID != nullptr) {
search_cfg[knowhere::meta::TRACE_ID] =
tracer::GetTraceIDAsStr(&search_info.trace_ctx_);
search_cfg[knowhere::meta::SPAN_ID] =
tracer::GetSpanIDAsStr(&search_info.trace_ctx_);
search_cfg[knowhere::meta::TRACE_FLAGS] =
search_info.trace_ctx_.traceFlags;
}
// TODO caiyd: will enable this after adding switch for trace
// if (search_info.trace_ctx_.traceID != nullptr &&
// search_info.trace_ctx_.spanID != nullptr) {
// search_cfg[knowhere::meta::TRACE_ID] =
// tracer::GetTraceIDAsStr(&search_info.trace_ctx_);
// search_cfg[knowhere::meta::SPAN_ID] =
// tracer::GetSpanIDAsStr(&search_info.trace_ctx_);
// search_cfg[knowhere::meta::TRACE_FLAGS] =
// search_info.trace_ctx_.traceFlags;
// }
return search_cfg;
}