From 120164b0a2da17b4b65519653f174e439884979d Mon Sep 17 00:00:00 2001 From: Gao Date: Wed, 8 Feb 2023 19:40:31 +0800 Subject: [PATCH] Remove unnecessary plan deserialization (#22056) Signed-off-by: chasingegg --- internal/querynode/task_search.go | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/internal/querynode/task_search.go b/internal/querynode/task_search.go index 65dced852e..f98a9ad11e 100644 --- a/internal/querynode/task_search.go +++ b/internal/querynode/task_search.go @@ -56,7 +56,6 @@ type searchTask struct { otherTasks []*searchTask cpuOnce sync.Once plan *planpb.PlanNode - qInfo *planpb.QueryInfo } func (s *searchTask) PreExecute(ctx context.Context) error { @@ -70,21 +69,6 @@ func (s *searchTask) PreExecute(ctx context.Context) error { return nil } -func (s *searchTask) init() error { - if s.iReq.GetSerializedExprPlan() != nil { - s.plan = &planpb.PlanNode{} - err := proto.Unmarshal(s.iReq.GetSerializedExprPlan(), s.plan) - if err != nil { - return err - } - switch s.plan.GetNode().(type) { - case *planpb.PlanNode_VectorAnns: - s.qInfo = s.plan.GetVectorAnns().GetQueryInfo() - } - } - return nil -} - // TODO: merge searchOnStreaming and searchOnHistorical? func (s *searchTask) searchOnStreaming() error { // check ctx timeout @@ -429,9 +413,5 @@ func newSearchTask(ctx context.Context, src *querypb.SearchRequest) (*searchTask PlaceholderGroup: src.Req.GetPlaceholderGroup(), MetricType: src.Req.GetMetricType(), } - err := target.init() - if err != nil { - return nil, err - } return target, nil }