From 0da3c712ec277982e19b47572312ab6e81574c1e Mon Sep 17 00:00:00 2001 From: groot Date: Thu, 26 Mar 2020 19:59:49 +0800 Subject: [PATCH] HasTable with a not exist table name, return error status (#1761) Signed-off-by: groot --- core/src/server/delivery/request/HasTableRequest.cpp | 4 ---- core/unittest/server/test_rpc.cpp | 4 ---- 2 files changed, 8 deletions(-) diff --git a/core/src/server/delivery/request/HasTableRequest.cpp b/core/src/server/delivery/request/HasTableRequest.cpp index 9465ffbde8..cde5f9d3f4 100644 --- a/core/src/server/delivery/request/HasTableRequest.cpp +++ b/core/src/server/delivery/request/HasTableRequest.cpp @@ -46,11 +46,7 @@ HasTableRequest::OnExecute() { // step 2: check table existence status = DBWrapper::DB()->HasNativeTable(table_name_, has_table_); - fiu_do_on("HasTableRequest.OnExecute.table_not_exist", status = Status(milvus::SERVER_UNEXPECTED_ERROR, "")); fiu_do_on("HasTableRequest.OnExecute.throw_std_exception", throw std::exception()); - if (!status.ok()) { - return status; - } // only process root table, ignore partition table if (has_table_) { diff --git a/core/unittest/server/test_rpc.cpp b/core/unittest/server/test_rpc.cpp index 6c095ac564..8560ad9db4 100644 --- a/core/unittest/server/test_rpc.cpp +++ b/core/unittest/server/test_rpc.cpp @@ -206,10 +206,6 @@ TEST_F(RpcHandlerTest, HAS_TABLE_TEST) { ASSERT_EQ(error_code, ::milvus::grpc::ErrorCode::SUCCESS); fiu_init(0); - fiu_enable("HasTableRequest.OnExecute.table_not_exist", 1, NULL, 0); - handler->HasTable(&context, &request, &reply); - ASSERT_NE(reply.status().error_code(), ::milvus::grpc::ErrorCode::SUCCESS); - fiu_disable("HasTableRequest.OnExecute.table_not_exist"); fiu_enable("HasTableRequest.OnExecute.throw_std_exception", 1, NULL, 0); handler->HasTable(&context, &request, &reply);