milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix flock, lock the pid file during the processing is running (#5037) 

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
pull/5046/head
neza2017 2021-04-26 09:28:23 +08:00 committed by GitHub
parent 53b5092b3a
commit 0d68c3f2fd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 36 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

79
cmd/distributed/main.go
View File

@ -14,6 +14,7 @@ package main
import (
"flag"
"fmt"
"io/ioutil"
"os"
"path"
"syscall"
@ -21,38 +22,30 @@ import (
"github.com/milvus-io/milvus/cmd/distributed/roles"
)
func run(serverType, runtTimeDir string) error {
fileName := serverType + ".pid"
_, err := os.Stat(path.Join(runtTimeDir, fileName))
var fd *os.File
if os.IsNotExist(err) {
if fd, err = os.OpenFile(path.Join(runtTimeDir, fileName), os.O_CREATE|os.O_WRONLY, 0664); err != nil {
return err
}
defer func() {
_ = syscall.Close(int(fd.Fd()))
_ = os.Remove(path.Join(runtTimeDir, fileName))
}()
if err := syscall.Flock(int(fd.Fd()), syscall.LOCK_EX|syscall.LOCK_NB); err != nil {
return err
}
_, _ = fd.WriteString(fmt.Sprintf("%d", os.Getpid()))
func run(serverType, runtTimeDir, svrAliase string) error {
var fileName string
if len(svrAliase) != 0 {
fileName = fmt.Sprintf("%s-%s.pid", serverType, svrAliase)
} else {
if fd, err = os.OpenFile(path.Join(runtTimeDir, fileName), os.O_WRONLY, 0664); err != nil {
return fmt.Errorf("service %s is running, error = %w", serverType, err)
}
if err := syscall.Flock(int(fd.Fd()), syscall.LOCK_EX|syscall.LOCK_NB); err != nil {
return fmt.Errorf("service %s is running, error = %w", serverType, err)
}
defer func() {
_ = syscall.Close(int(fd.Fd()))
_ = os.Remove(path.Join(runtTimeDir, fileName))
}()
fd.Truncate(0)
_, _ = fd.WriteString(fmt.Sprintf("%d", os.Getpid()))
fileName = serverType + ".pid"
}
var fd *os.File
var err error
if fd, err = os.OpenFile(path.Join(runtTimeDir, fileName), os.O_CREATE|os.O_RDWR, 0664); err != nil {
return fmt.Errorf("service %s is running, error = %w", serverType, err)
}
fmt.Println("open pid file:", path.Join(runtTimeDir, fileName))
if err := syscall.Flock(int(fd.Fd()), syscall.LOCK_EX|syscall.LOCK_NB); err != nil {
return fmt.Errorf("service %s is running, error = %w", serverType, err)
}
fmt.Println("lock pid file")
defer func() {
_ = syscall.Close(int(fd.Fd()))
_ = os.Remove(path.Join(runtTimeDir, fileName))
}()
fd.Truncate(0)
_, _ = fd.WriteString(fmt.Sprintf("%d", os.Getpid()))
role := roles.MilvusRoles{}
switch serverType {
@ -121,36 +114,36 @@ func makeRuntimeDir(dir string) error {
if !st.IsDir() {
return fmt.Errorf("%s is exist, but is not directory", dir)
}
tmpFile := path.Join(dir, "testTmp")
var fd *os.File
if fd, err = os.OpenFile(tmpFile, os.O_CREATE|os.O_WRONLY, 0664); err != nil {
tmpFile, err := ioutil.TempFile(dir, "tmp")
if err != nil {
return err
}
syscall.Close(int(fd.Fd()))
os.Remove(tmpFile)
fileName := tmpFile.Name()
tmpFile.Close()
os.Remove(fileName)
return nil
}
func main() {
if len(os.Args) < 3 {
_, _ = fmt.Fprint(os.Stderr, "usage: milvus-distributed [command] [server type] [flags]\n")
_, _ = fmt.Fprint(os.Stderr, "usage: milvus [command] [server type] [flags]\n")
return
}
command := os.Args[1]
serverType := os.Args[2]
flags := flag.NewFlagSet(os.Args[0], flag.ExitOnError)
//flags.BoolVar()
var svrAliase string
flags.StringVar(&svrAliase, "alias", "", "set aliase")
if err := flags.Parse(os.Args[3:]); err != nil {
os.Exit(-1)
}
runtimeDir := "/run/milvus-distributed"
runtimeDir := "/run/milvus"
if err := makeRuntimeDir(runtimeDir); err != nil {
_, _ = fmt.Fprintf(os.Stderr, "set runtime dir at : %s failed, set it to /tmp/milvus-distributed directory\n", runtimeDir)
runtimeDir = "/tmp/milvus-distributed"
_, _ = fmt.Fprintf(os.Stderr, "set runtime dir at : %s failed, set it to /tmp/milvus directory\n", runtimeDir)
runtimeDir = "/tmp/milvus"
if err = makeRuntimeDir(runtimeDir); err != nil {
_, _ = fmt.Fprintf(os.Stderr, "create runtime director at : %s failed\n", runtimeDir)
os.Exit(-1)
@ -159,7 +152,7 @@ func main() {
switch command {
case "run":
if err := run(serverType, runtimeDir); err != nil {
if err := run(serverType, runtimeDir, svrAliase); err != nil {
panic(err)
}
case "stop":