milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove kafka consumer ack (#20518) 

Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
pull/20556/head
jaime 2022-11-13 18:51:06 +08:00 committed by GitHub
parent 2284378f87
commit 056aebf9c2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/mq/msgstream/mqwrapper/kafka/kafka_consumer.go
View File

@ -198,8 +198,9 @@ func (kc *Consumer) internalSeek(offset kafka.Offset, inclusive bool) error {
}
func (kc *Consumer) Ack(message mqwrapper.Message) {
kafkaMsg, _ := message.(*kafkaMessage)
kc.c.CommitMessage(kafkaMsg.msg)
// Do nothing
// Kafka retention mechanism only depends on retention configuration,
// it does not relate to the commit with consumer's offsets.
}
func (kc *Consumer) GetLatestMsgID() (mqwrapper.MessageID, error) {