milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[skip e2e]Update label cmd (#14075) 

Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
pull/14123/head
yanliang567 2021-12-23 23:19:14 +08:00 committed by GitHub
parent 0c43d18915
commit 0272ebf746
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CODE_REVIEW.md
View File

@ -6,8 +6,8 @@ All PRs are checked in automatically by the sre-robot, with the following condit
2. All test passed and code coverage check passed, with a `ci-passed` label 2. All test passed and code coverage check passed, with a `ci-passed` label
- Notes: If there is a `[skip e2e]` tag in the commit message, it skips running e2e tests automatically, - Notes: If there is a `[skip e2e]` tag in the commit message, it skips running e2e tests automatically,
but it still runs UT tests and code checkers. but it still runs UT tests and code checkers.
3. Reviewer passed, with a `lgtm` label 3. Reviewer passed, with a `/lgtm` label
4. Approver passed, with a `approved` label 4. Approver passed, with a `/approve` label
Generally speaking, reviewer is volunteered and can be anyone in the community who is familiar with the packages the PR modifies. Generally speaking, reviewer is volunteered and can be anyone in the community who is familiar with the packages the PR modifies.
Reviewers are responsible for the logic correctness, error handling, unit test coverage and code readability. Reviewers are responsible for the logic correctness, error handling, unit test coverage and code readability.