milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix a nil pointer bug and improve comments (#7625) 

Issue: #7624
Signed-off-by: sunby <bingyi.sun@zilliz.com>
pull/9510/head
sunby 2021-10-08 19:05:25 +08:00 committed by GitHub
parent b633fc99e4
commit 006303285f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
internal/datacoord/segment_manager.go
View File

@ -67,15 +67,15 @@ const segmentMaxLifetime = 24 * time.Hour
// Manager manage segment related operations.
type Manager interface {
// AllocSegment allocate rows and record the allocation.
// AllocSegment allocates rows and record the allocation.
AllocSegment(ctx context.Context, collectionID, partitionID UniqueID, channelName string, requestRows int64) ([]*Allocation, error)
// DropSegment drop the segment from allocator.
// DropSegment drops the segment from manager.
DropSegment(ctx context.Context, segmentID UniqueID)
// SealAllSegments sealed all segmetns of collection with collectionID and return sealed segments
// SealAllSegments seals all segments of collection with collectionID and return sealed segments
SealAllSegments(ctx context.Context, collectionID UniqueID) ([]UniqueID, error)
// GetFlushableSegments return flushable segment ids
// GetFlushableSegments returns flushable segment ids
GetFlushableSegments(ctx context.Context, channel string, ts Timestamp) ([]UniqueID, error)
// ExpireAllocations notify segment status to expire old allocations
// ExpireAllocations notifies segment status to expire old allocations
ExpireAllocations(channel string, ts Timestamp) error
}
@ -341,7 +341,7 @@ func (s *SegmentManager) estimateMaxNumOfRows(collectionID UniqueID) (int, error
return s.estimatePolicy(collMeta.Schema)
}
// DropSegment puts back all the allocation of provided segment
// DropSegment drop the segment from manager.
func (s *SegmentManager) DropSegment(ctx context.Context, segmentID UniqueID) {
sp, _ := trace.StartSpanFromContext(ctx)
defer sp.Finish()
@ -356,6 +356,7 @@ func (s *SegmentManager) DropSegment(ctx context.Context, segmentID UniqueID) {
segment := s.meta.GetSegment(segmentID)
if segment == nil {
log.Warn("failed to get segment", zap.Int64("id", segmentID))
return
}
s.meta.SetAllocations(segmentID, []*Allocation{})
for _, allocation := range segment.allocations {
@ -363,7 +364,7 @@ func (s *SegmentManager) DropSegment(ctx context.Context, segmentID UniqueID) {
}
}
// SealAllSegments seals all segments of provided collectionID
// SealAllSegments seals all segmetns of collection with collectionID and return sealed segments
func (s *SegmentManager) SealAllSegments(ctx context.Context, collectionID UniqueID) ([]UniqueID, error) {
sp, _ := trace.StartSpanFromContext(ctx)
defer sp.Finish()