Commit Graph

3 Commits (915fe136f3be7a41a8cf5126a7b909b972a8416a)

Author SHA1 Message Date
Slava Semushin 55ee59477e en/examples/minikube/Dockerfile: modify CMD to use exec form. (#18618)
Quote from https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#cmd:
%
CMD should almost always be used in the form of CMD ["executable", "param1", "param2"…]
%
This is because shell form doesn't pass the signal to an executable and it leads a longer shutdown time as Docker has to kill a process after some timeout. See for details: https://docs.docker.com/engine/reference/builder/#shell-form-entrypoint-example

An example on official NodeJS site is also uses that form: https://nodejs.org/de/docs/guides/nodejs-docker-webapp/#creating-a-dockerfile
2020-01-11 10:23:37 -08:00
JJ Asghar dd1509fa1b Update Dockerfile (#10441)
Updated the `node` version.
2018-10-03 17:28:52 -07:00
Qiming 3dd65e4e95 Consolidate YAML files [part-14] (#9379)
This PR deals with the getting started guides (windows) and tutorials
sections. Since the YAML files in the windows directory currently are not
referenced at all, this PR refactored the markdown file to correct this
problem. When appropriate, we use the YAML content from the markdown in
the extracted version.
2018-07-03 23:58:20 -07:00