Commit Graph

4 Commits (5d6ca9ef5c052d24f618a03e34c22c7cd582f5bf)

Author SHA1 Message Date
Misty Linville 5ae0d0dd8d Reorganize docs contrib guide (#9510)
* Reorganize docs contrib guide

* Address first round of feedback from Brad, Jared

* Standardize on 'SIG Docs'

* Address more feedback

* Rewrites to participating.md

* Tweak navigation titles

* Document PR Wrangler

* Document SIG Docs chairperson

* Fix codeblock that shows how to use <codenew>

It was being interpreted as a Hugo shortcode.
2018-08-06 16:15:57 -07:00
Chris Morgan 764a751c5b Fix the semantically very broken search box (#9408)
This was very annoyingly very broken. *Very* broken.

Two primary issues:

1. Autofocus. Autofocus should only be used on a field when it is the
   expected action on the page, because it steals keyboard events such
   as the arrow keys and Space for navigation, and causes users of
   screen readers confusion as they’re thrown into a strange place.

   It’d be just barely OK to use it on search pages, but used on
   *every* page in the documentation, it’s just *super* annoying.

2. Not being a form. I have *no* idea why anyone would ever have
   written it the way it was—it’s just awful from end to end, a bad
   reimplementation of a subset of native browser functionality.
   It’s a form, let it *be* a form.

   Possibly the most baffling part of it was the use of location.replace
   which breaks the back button. I just… why!?

   While I was at it, I gave the search box an aria-label for good
   measure, but I didn’t change its type to "search" because that has
   UI implications on some platforms that I’m too lazy to deal with.

This is still pretty bad, because that magnifying glass is done in CSS
rather than being a fair dinkum submit button, but I just wanted a
quick fix because the autofocus issue is annoying me *so much*.
2018-07-18 15:24:12 -07:00
Andrew Chen 4691ee4ef7 fix column size bug -- add decimal number to div operation (+7 squashed commits) (#8631)
Squashed commits:
[b645d8e] remove debug
[47ba8b9] test new column size
[2f12ba5] use float
[b16f50b] test division
[789e289] test ceil
[012f6ad] debug offset
[514b529] debug column size
2018-06-06 15:20:24 -07:00
Bjørn Erik Pedersen 7f3b633aa0 Convert site to Hugo (#8316)
This commit converts content and layout to use Hugo.
2018-05-05 09:00:51 -07:00