This was very annoyingly very broken. *Very* broken.
Two primary issues:
1. Autofocus. Autofocus should only be used on a field when it is the
expected action on the page, because it steals keyboard events such
as the arrow keys and Space for navigation, and causes users of
screen readers confusion as they’re thrown into a strange place.
It’d be just barely OK to use it on search pages, but used on
*every* page in the documentation, it’s just *super* annoying.
2. Not being a form. I have *no* idea why anyone would ever have
written it the way it was—it’s just awful from end to end, a bad
reimplementation of a subset of native browser functionality.
It’s a form, let it *be* a form.
Possibly the most baffling part of it was the use of location.replace
which breaks the back button. I just… why!?
While I was at it, I gave the search box an aria-label for good
measure, but I didn’t change its type to "search" because that has
UI implications on some platforms that I’m too lazy to deal with.
This is still pretty bad, because that magnifying glass is done in CSS
rather than being a fair dinkum submit button, but I just wanted a
quick fix because the autofocus issue is annoying me *so much*.
Changes that will help upcoming consolidation work:
- Add variable `githubWebsiteRaw` to config.toml to facilitate building
links to raw YAML files
- Revise `codenew` shortcode to generate links to raw YAML files instead
of github.com file view;
- Rename `artifacts` directory to `examples` to better reflect its usage;
Accompanied changes as show cases:
- Moved `deployment.yaml`, `deployment-update.yaml` and
`deployment-scale.yaml` to the new `examples/application` subdirectory;
- Removed duplicate instances of the above YAML files in other
directories;
- Update example_test.go to test the relocated YAML files and removed
testing for files that no longer needed.
This is an attempt to consolidate YAML files so that:
- They can remain untouched when we moving the documents around;
- Contributors do not have to change the test cases each time a
documentation is moved;
- We can encourage referencing the existing YAMLs from different
concept or task pages when possible.
Chris Morgan
Andrew Chen
craigbox
Misty Linville
Qiming
Jorge O. Castro
Takuya Tokuda
Paris
Kaitlyn Barnard
T N
Bjørn Erik Pedersen
Kazuki Suda