From 21e2046efbd13f9999aa733098a1889268ee3794 Mon Sep 17 00:00:00 2001 From: HYUNSIK AEOM <t_aeom@naver.com> Date: Wed, 16 Mar 2022 21:47:28 +0900 Subject: [PATCH] [ko] fix a mistranslated; maxUnavailable rounds down, maxSurge rounds up. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit has been mistranslated. π₯Ί rounding down is 'λ΄λ¦Ό' in Korean. rounding up is 'μ¬λ¦Ό' in Korean. If calculate 'λ°μ¬λ¦Ό' when desired replica 1, both maxUnavailable and maxSurge should be 0. In English documentation, there was written explicitly 'rounding down', 'rounding up'. Also in code, explicitly using 'Math.Ceil' and 'Math.floor'. - Related codes + [deployment_util.go > maxSurge](https://github.com/kubernetes/kubernetes/blob/7152825c0695d62fe06b47cc3e1699095290d73f/pkg/controller/deployment/util/deployment_util.go#L456) + [deployment_util.go > ResolveFenceposts](https://github.com/kubernetes/kubernetes/blob/7152825c0695d62fe06b47cc3e1699095290d73f/pkg/controller/deployment/util/deployment_util.go#L849) + [util/instr.go > GetScaledValueFromIntOrPercent](https://github.com/kubernetes/kubernetes/blob/7152825c0695d62fe06b47cc3e1699095290d73f/staging/src/k8s.io/apimachinery/pkg/util/intstr/intstr.go#L146) - Korean dictionary + [μ¬λ¦Ό: rounding up](https://krdict.korean.go.kr/m/eng/searchResultView?wordMatchFlag=N¤tPage=1&mainSearchWord=%EC%98%AC%EB%A6%BC&sort=&searchType=W&proverbType=&exaType=&ParaWordNo=68195&font_size=12&nationCode=6&nation=eng&viewType=A) + [λ°μ¬λ¦Ό: rounding off](https://krdict.korean.go.kr/m/eng/searchResultView?wordMatchFlag=N¤tPage=1&mainSearchWord=%EB%B0%98%EC%98%AC%EB%A6%BC&sort=&searchType=W&proverbType=&exaType=&ParaWordNo=57172&font_size=12&nationCode=6&nation=eng&viewType=A) --- content/ko/docs/concepts/workloads/controllers/deployment.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/ko/docs/concepts/workloads/controllers/deployment.md b/content/ko/docs/concepts/workloads/controllers/deployment.md index e9725d2eea..7bcd5e94c5 100644 --- a/content/ko/docs/concepts/workloads/controllers/deployment.md +++ b/content/ko/docs/concepts/workloads/controllers/deployment.md @@ -1131,7 +1131,7 @@ API λ²μ `apps/v1` μμλ `.spec.selector` μ `.metadata.labels` μ΄ μ€ `.spec.strategy.rollingUpdate.maxUnavailable` μ μ λ°μ΄νΈ νλ‘μΈμ€ μ€μ μ¬μ©ν μ μλ μ΅λ νλμ μλ₯Ό μ§μ νλ μ νμ νλμ΄λ€. μ΄ κ°μ μ λ μ«μ(μ: 5) λλ μλν νλ λΉμ¨(μ: 10%)μ΄ λ μ μλ€. -μ λ κ°μ λ°μ¬λ¦Όν΄μ λ°±λΆμ¨λ‘ κ³μ°νλ€. +μ λ κ°μ λ΄λ¦Όν΄μ λ°±λΆμ¨λ‘ κ³μ°νλ€. λ§μ½ `.spec.strategy.rollingUpdate.maxSurge` κ° 0μ΄λ©΄ κ°μ΄ 0μ΄ λ μ μλ€. κΈ°λ³Έ κ°μ 25% μ΄λ€. μλ₯Ό λ€μ΄ μ΄ κ°μ 30%λ‘ μ€μ νλ©΄ λ‘€λ§μ λ°μ΄νΈ μμμ μ¦κ° μ΄μ λ ν리카μ μ ν¬κΈ°λ₯Ό @@ -1144,7 +1144,7 @@ API λ²μ `apps/v1` μμλ `.spec.selector` μ `.metadata.labels` μ΄ μ€ `.spec.strategy.rollingUpdate.maxSurge` λ μλν νλμ μμ λν΄ μμ±ν μ μλ μ΅λ νλμ μλ₯Ό μ§μ νλ μ νμ νλμ΄λ€. μ΄ κ°μ μ λ μ«μ(μ: 5) λλ μλν νλ λΉμ¨(μ: 10%)μ΄ λ μ μλ€. `MaxUnavailable` κ°μ΄ 0μ΄λ©΄ μ΄ κ°μ 0μ΄ λ μ μλ€. -μ λ κ°μ λ°μ¬λ¦Όν΄μ λ°±λΆμ¨λ‘ κ³μ°νλ€. κΈ°λ³Έ κ°μ 25% μ΄λ€. +μ λ κ°μ μ¬λ¦Όν΄μ λ°±λΆμ¨λ‘ κ³μ°νλ€. κΈ°λ³Έ κ°μ 25% μ΄λ€. μλ₯Ό λ€μ΄ μ΄ κ°μ 30%λ‘ μ€μ νλ©΄ λ‘€λ§μ λ°μ΄νΈ μμμ μ λ ν리카μ μ ν¬κΈ°λ₯Ό μ¦μ μ‘°μ ν΄μ κΈ°μ‘΄ λ° μ νλμ μ 체 κ°―μλ₯Ό μλν νλμ 130%λ₯Ό λμ§ μλλ‘ νλ€.