19 lines
647 B
Markdown
19 lines
647 B
Markdown
|
---
|
||
|
|
title: Approver
|
||
|
|
id: approver
|
||
|
|
date: 2018-04-12
|
||
|
|
full_link:
|
||
|
|
short_description: >
|
||
|
|
A person who can review and approve Kubernetes code contributions.
|
||
|
|
|
||
|
|
aka:
|
||
|
|
tags:
|
||
|
|
- community
|
||
|
|
---
|
||
|
|
A person who can review and approve Kubernetes code contributions.
|
||
|
|
|
||
|
|
<!--more-->
|
||
|
|
|
||
|
|
While code review is focused on code quality and correctness, approval is focused on the holistic acceptance of a contribution. Holistic acceptance includes backwards/forwards compatibility, adhering to API and flag conventions, subtle performance and correctness issues, interactions with other parts of the system, and others. Approver status is scoped to a part of the codebase.
|
||
|
|
|