Commit Graph

313 Commits (fe05e0d372a1b0896f2bb71c8ed05409f5bc0fbb)

Author SHA1 Message Date
Ben Ebsworth 6fa12ea036 fixed linting 2019-06-29 21:33:19 +10:00
Jose Donizetti ad97983d9e # This is a combination of 8 commits.
# This is the 1st commit message:

Fix doc comment version.gitCommitID doc


# This is the commit message #2:

Add hyperkit doc


# This is the commit message #3:

Add commit id to docker-machine-driver-kvm2 version


# This is the commit message #4:

removed label selector for registry-proxy daemonset

# This is the commit message #5:

Add support to custom qemu uri on kvm2 driver


# This is the commit message #6:

Improve hyperkit vm stop


# This is the commit message #7:

Make virtualbox DNS settings configurable 


# This is the commit message #8:

added integration tests for registry addon
2019-06-29 18:27:47 +10:00
Jose Donizetti 9dfe660c64 Add support to custom qemu uri on kvm2 driver 2019-06-28 14:12:58 -07:00
Medya Ghazizadeh e0c20a4202
Merge pull request #4558 from afbjorklund/reportcard-new
Fix the reportcard: gofmt, golint and gocyclo
2019-06-24 11:44:42 -07:00
Thomas Stromberg 7d394fa597 Add missing import and parens 2019-06-24 11:42:05 +08:00
Thomas Stromberg a9ec145bcb Allow --kubernetes-version to be specified without the leading v 2019-06-24 10:29:09 +08:00
Anders F Björklund f20f223c02 Decrease cyclomatic complexity
Here is the report (from gocyclo), before:

21 tests (*SSHServer).Start pkg/minikube/tests/ssh_mock.go:76:1
19 cmd runStart cmd/minikube/cmd/start.go:173:1
18 integration testTunnel test/integration/tunnel_test.go:40:1
17 extract checkCallExpression pkg/minikube/extract/extract.go:198:1
17 kubeadm TestGenerateConfig pkg/minikube/bootstrapper/kubeadm/kubeadm_test.go:133:1
16 kvm (*Driver).deleteNetwork pkg/drivers/kvm/network.go:153:1
2019-06-22 17:21:42 +02:00
Sharif Elgamal 44856928f6
Merge pull request #4474 from medyagh/4418_fixTestVersionUpgrade
adding retriable http get
2019-06-14 10:09:46 -07:00
Medya Gh 657469310c Use retryable http to avoid connection flakes 2019-06-13 22:58:14 -07:00
Y.Horie 8c88558cb0 Fix busybox version in integration tests
Fixes https://github.com/kubernetes/minikube/issues/4475 related to this https://github.com/docker-library/busybox/issues/48
2019-06-13 22:30:27 -07:00
Medya Gh 68b5ed9916 check error 2019-06-12 11:15:34 -07:00
Medya Gh d3855d4b09 adding retriable http get 2019-06-12 10:44:04 -07:00
Medya Gh c58a3b63db Fixing filepath to be os agnostic 2019-06-05 19:31:50 -07:00
Medya Gh b9ecd558e8 fixing file path for windows 2019-06-05 16:58:52 -07:00
Medya Gh 15cc4f8a64 Adding non-parallel dashboard test for proxy 2019-06-03 19:22:26 -07:00
Medya Gh ed8d55c64a Fixing TestProxy Setup
making sure minikube is deleted before setup to avoid https://github.com/kubernetes/minikube/issues/4132
2019-06-03 19:14:05 -07:00
josedonizetti c7bace6903 Fix --kvm-network integration test 2019-05-23 02:30:21 -03:00
josedonizetti a20d789613 Improve --kvm-network integration test
Change the network to test-net to avoid conflicts.
2019-05-22 18:03:15 -03:00
josedonizetti 5d02839e74 Add integration test to flag --kvm-network 2019-05-22 17:25:42 -03:00
tstromberg 230443ceb6 Use NewMinikubeRunner so that release test uses the right VM driver 2019-05-20 14:28:06 -07:00
Thomas Strömberg 9d09ff069b
Merge pull request #4229 from medyagh/no_proxy_for_self
Allow minikube to function with misconfigured NO_PROXY value
2019-05-20 11:22:12 -07:00
Medya Gh c428ce5ebd Fix typo 2019-05-19 14:10:46 -07:00
Medya Gh 871c2e6704 Better clean up after tesdt proxy setup 2019-05-19 14:07:02 -07:00
Medya Gh 42e40e3bab Debug 2019-05-19 00:40:01 -07:00
Jan Janik 21b9e95647 Whitelist for kubeadm extra args 2019-05-17 17:11:03 +12:00
Jan Janik 6fe47f3677 Expose ‘—pod-network-cidr’ argument in minikube 2019-05-17 16:59:06 +12:00
Medya Gh 0d58773af3 Clean up after unit test 2019-05-16 20:37:29 -07:00
Medya Gh 6484548a1f fix formatting 2019-05-16 15:38:28 -07:00
Medya Gh a1e34b01a1 Improve http server shutdown handling 2019-05-16 15:26:24 -07:00
Medya Gh 3ff806a595 Added unittest and rebase 2019-05-16 14:44:01 -07:00
Thomas Stromberg c91d8e85c2 Test the upgrade of Kubernetes versions (oldest->newest) 2019-05-16 07:15:53 -07:00
Medya Gh 08d19bf15a Improve formatting and messages 2019-05-15 15:39:50 -07:00
Medya Gh b8501ea4f4 Fix formatting 2019-05-15 15:30:39 -07:00
Medya Gh a0c6013e71 Fixed Error handling for http serve 2019-05-15 15:05:29 -07:00
Medya Gh 10799333f1 Added integration tests for proxy 2019-05-15 15:00:45 -07:00
tstromberg 313cf575fe Merge branch 'master' into gomods 2019-05-14 21:06:00 -07:00
Thomas Stromberg 25579f5a58 Use consistent names for k8s API imports 2019-05-13 21:57:59 -07:00
Thomas Stromberg 6e693d22ee lint-a-geddon is here 2019-05-13 21:43:52 -07:00
tstromberg 9a9f9edf5f First pass at lint-ageddon 2019-05-13 18:31:55 -07:00
Himanshu Pandey 64f990cec1 Updated the test case 2019-05-07 13:58:33 -07:00
Himanshu Pandey e23a78489c Added a param in the test case to find the current-context after stop 2019-05-03 16:18:36 -07:00
Himanshu Pandey dd8d3cf900 minor code change: Added strings.TrimRight() 2019-05-03 14:12:11 -07:00
Himanshu Pandey fd7277ba4d Changed the error message style in test case. 2019-05-02 12:17:33 -07:00
Himanshu Pandey a533b5653f Fixed the test case 2019-05-02 09:47:08 -07:00
Himanshu Pandey a4018bfa72 Fixed the build error and formatting 2019-05-02 09:04:08 -07:00
Himanshu Pandey fb0127f352 Fixed gofmt errors 2019-04-30 16:24:30 -07:00
Himanshu Pandey c8af727416 Added tests to check current-context on start and stop of minikube 2019-04-30 15:32:40 -07:00
Balint Pato 3ebb16c678
fix tunnel integration tests for driver None (#4105)
* added more wait to the integration tests for the tunnel
2019-04-25 08:49:24 -07:00
Anders F Björklund a73dfc5f9e Merge branch 'master' into cyclo 2019-04-12 20:03:20 +02:00
Benn Linger b7ffe5b7c2 Combined non-default apiserver port test with containerd test 2019-04-05 18:36:35 -04:00
Benn Linger d102550644 Fixed status checking with non-default apiserver-port. 2019-04-04 21:43:43 -04:00
Thomas Stromberg 614f19b486 Add CNI flags to feature_gates_newest 2019-03-26 20:26:47 -07:00
Thomas Strömberg ca51bada64
Merge pull request #3965 from tstromberg/v1.14-tmpl
Fix all the kubeadm config generation bugs, add tests across versions
2019-03-26 15:32:30 -07:00
Thomas Stromberg 7233a2d50d Allow mount to work when the uid/gid of docker changes 2019-03-26 14:27:50 -07:00
Anders F Björklund 4667c28164 Merge branch 'master' into cyclo 2019-03-26 07:16:28 +01:00
Thomas Stromberg 9004134eb8 Fix invalid feature-gates argument 2019-03-25 21:02:44 -07:00
Thomas Stromberg 9f753c3027 Fix all the kubeadm config generation bugs I could find, add tests across versions 2019-03-25 18:25:01 -07:00
Thomas Strömberg c3d0b33d21
Merge pull request #3929 from sharifelgamal/version-upgrade-test
Adding test to make sure HEAD can run on VM created by latest release
2019-03-25 13:27:58 -07:00
Sharif Elgamal 4fc03fe1ef
addressing comments 2019-03-25 11:50:06 -07:00
Thomas Strömberg cc5d4e9724
Merge branch 'master' into rkt-remove 2019-03-25 11:31:09 -07:00
Anders F Björklund 71b3e3ec5d Store the toolbox on the disk instead of rootfs
There was a lack of "disk" space, when using memory.

This also makes the toolbox persistent over reboots.
2019-03-25 07:41:21 +01:00
Anders F Björklund 2590fc7b9a Remove the rkt container runtime
It has not been updated since kubernetes 1.9 or so
2019-03-24 08:50:58 +01:00
Thomas Strömberg cbac94a53d
Merge pull request #3879 from marcosdiez/extra_config_for_kubeadm
--extra-config now work for kubeadm as well
2019-03-21 22:03:06 -07:00
Thomas Stromberg 1ff174b796 Run: gofmt -s -w 2019-03-21 22:00:14 -07:00
Sharif Elgamal c3849b3781
gofmt 2019-03-21 17:46:46 -07:00
Sharif Elgamal ffaa27b256
Adding test to make sure HEAD can run on VM created by latest release 2019-03-21 17:36:13 -07:00
Marcos Diez 8aec728a86 start_stop_delete_test.go now tests for "--extra-config kubeadm.ignore-preflight-errors=SystemVerification" too 2019-03-21 09:11:55 -03:00
Thomas Strömberg 4756b15bc1
Merge branch 'master' into lint 2019-03-20 10:16:09 -07:00
Anders F Björklund 03bdce47ee Decrease cyclomatic complexity for test
Mostly by using the "extract method" pattern.

Here was the report (from gocyclo), before:

17 tunnel TestTunnelManagerCleanup pkg/minikube/tunnel/tunnel_manager_test.go:174:1
44 tunnel TestTunnel pkg/minikube/tunnel/tunnel_test.go:35:1
34 kubeconfig configEquals pkg/util/kubeconfig/config_test.go:420:1
25 integration testMounting test/integration/mount_test.go:36:1
18 integration testTunnel test/integration/tunnel_test.go:37:1
2019-03-16 23:04:24 +01:00
Anders F Björklund edf46f003f Document all exported functions outside minikube 2019-03-16 16:57:37 +01:00
Thomas Stromberg 4f44208ba3 Refactor functional tests to not rely on SetRuntime, use short variable name 2019-03-08 12:30:41 -08:00
Thomas Stromberg 02a06a8da6 Second Start call should also pass in the new test.args list 2019-03-06 15:50:57 -08:00
Thomas Stromberg e09133892f Fix docker/containerd caching, improve msgs, add tests 2019-02-27 13:58:33 -08:00
Thomas Stromberg 61d0516bba Fix TestStartStop so that none tests are executed 2019-02-14 20:26:24 -08:00
Anders F Björklund abb5fc0af0 Show name as CRI-O, even if class is CRIO
Should use the proper name for display, even if we use a name more
suitable to naming classes and methods for the implementation...

Also use the --runtime=cri-o when testing, and update the github
repository now that cri-o has graduated from incubator to a sig.

See https://cri-o.io/
2019-02-12 21:03:51 +01:00
Anders F Björklund 78806674f3 Merge branch 'master' into defaults 2019-02-09 18:25:27 +01:00
Thomas Stromberg 966b245dc6 Refactor and centralize container runtime code into a cruntime package 2019-02-05 14:42:12 -08:00
Anders F Björklund 7ef2918100 Remove default cni flags from integration tests 2019-02-05 20:03:29 +01:00
Thomas Strömberg c27d1a0213
Merge pull request #3536 from tstromberg/crio-test
Add CRI-O to TestStartStop
2019-01-25 10:16:00 -08:00
Thomas Stromberg a9ca1d7186 Add --enable-default-cni for CRIO 2019-01-24 16:08:40 -08:00
Nicholas Goozeff d516caadb3
Merge branch 'master' into bug3044 2019-01-20 20:58:15 +11:00
Thomas Stromberg 9e0119b8e2 Add --network-plugin=cni as per afbjorklund's comment 2019-01-18 15:03:05 -08:00
Thomas Stromberg d499497056 Add CRIO flags support to MinikubeRunner.Start() 2019-01-17 10:57:54 -08:00
Thomas Stromberg 218cf179dd Fix T->t typo 2019-01-16 16:20:23 -08:00
Thomas Stromberg f2c7860eab Add CRI-O to TestStartStop 2019-01-16 15:13:20 -08:00
Thomas Strömberg 3aa83674a9
Merge pull request #3441 from brb/2907-no-cni-conf-by-default
Do not include the default CNI config by default
2019-01-15 17:14:20 -08:00
Thomas Stromberg 11f97460a2 Merge branch 'master' into crio-v1.13.0 2019-01-11 10:53:37 -08:00
Thomas Stromberg d1f4e787c6 Don't error if delete fails: there may not be a cluster to delete 2019-01-08 16:22:03 -08:00
Martynas Pumputis d982c4bf74 Do not include the default CNI config by default
Previously, minikube has been shipped with the default CNI config
(/etc/cni/net.d/k8s.conf) in its rootfs. This complicated a lot
when using a custom CNI plugin, as the default config was picked
by kubelet before the custom CNI plugin has installed its own CNI
config. So, the end result was that some Pods were attached to a
network defined in the default config, and some got managed by
the custom plugin.

This commit introduces the flag "--enable-default-cni" to
"minikube start" to trigger the provisioning of the default CNI
config.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
2019-01-03 09:23:29 +01:00
Thomas Stromberg 6f5c380ff6 RunDaemon: tee stderr for debugging 2018-12-21 13:07:49 -08:00
Thomas Stromberg 44a230bfa0 Remove dashboard deployment check from TestPersistence - it's no longer default 2018-12-21 12:03:15 -08:00
Thomas Stromberg 8aae0f72f8 Set --v=5, which seems to be the initial right level for testing 2018-12-20 10:16:47 -08:00
Thomas Stromberg 7f7587d96c Rename TeeWithPrefix to TeePrefix to match Go idioms 2018-12-20 09:54:09 -08:00
Thomas Stromberg 9b707fe234 Add TeeWithPrefix to ssh_runner as well 2018-12-19 17:03:55 -08:00
Thomas Stromberg ab5d433448 Make tee work with RunWithContext also 2018-12-19 11:16:08 -08:00
Thomas Stromberg bc5eb2a1f7 Stream command output from integration tests 2018-12-19 10:42:19 -08:00
priyawadhwa 1514511b7a Change restart policy on gvisor pod (#3445)
* Change restart policy on gvisor pod

Change the restart policy on the gvisor pod to Always. This way, if a
user runs

minikube addons enable gvisor
minikube stop
minikube start

when the addon manager tries to restart the gvisor pod, it will be
restarted and gvisor will start running automatically. This PR also adds an
integration test for this functionality.

* Test stop and start

* Revert test to delete

Revert test to delete for now, for some reason "stop" and then "start"
is failing both locally and in Jenkins for VirtualBox with a "panic test
timed out after 30 min" error
2018-12-11 18:39:57 -08:00
priyawadhwa 8f128a7d10 Enable gvisor addon in minikube (#3399)
This PR adds the code for enabling gvisor in minikube. It adds the pod
that will run when the addon is enabled, and the code for the image
which will run when this happens.

When gvisor is enabled, the pod will download runsc and the
gvisor-containerd-shim. It will replace the containerd config.toml and
restart containerd.

When gvisor is disabled, the pod will be deleted by the addon manager.
This will trigger a pre-stop hook which will revert the config.toml to
it's original state and restart containerd.
2018-12-07 15:27:22 -08:00
Thomas Strömberg ad415e252d
Merge pull request #3401 from tstromberg/cherry-2f81d
Add apiserver check to "status", and block "start" until it's healthy.
2018-12-07 15:20:07 -08:00
priyawadhwa 034046e931 Add integration test to make sure minikube starts and stops with cont… (#3394)
* Add integration test to make sure minikube starts and stops with containerd
* Skip testing containerd if using none driver
2018-12-05 10:23:36 -08:00