Commit Graph

17 Commits (f9e00f41953baa2c401c9be2a5e2395f0fe0a49e)

Author SHA1 Message Date
Sharif Elgamal 6552436311
Console output cleanup (#4825)
* Console output cleanup

* comment fix

* Fixing out.Out stutter

* Fix invalid template

* Change profile_list.go to new console functions

* more merge stuff
2019-07-19 17:00:51 -07:00
Medya Gh 453b8630f4 merge upstream 2019-07-18 11:50:55 -07:00
Medya Gh ed11f3ab0c merge upstream 2019-07-18 10:39:28 -07:00
Medya Gh cc2ae6a060 extract 2019-07-18 09:19:37 -07:00
Medya Ghazizadeh 5178c0b300
Merge branch 'master' into translation_outstyle 2019-07-17 18:12:45 -07:00
Sharif Elgamal 93263bc2bc
Templatizing more calls to console 2019-07-17 18:06:06 -07:00
Medya Gh e8ba9ccb74 reset lang json files 2019-07-17 18:04:45 -07:00
Medya Gh 97ba8854a6 more translation formatting 2019-07-17 17:37:39 -07:00
Thomas Stromberg 054fc946f1 Pass most tests 2019-07-17 17:13:12 -07:00
Medya Gh 7b219ebb46 Adding extract 2019-07-17 16:58:08 -07:00
Sharif Elgamal b40011b2e3
Add T versions of the console convenience functions (#4796)
* Add T versions of the console convenience functions

* more changes

* Make OutT and ErrT more convenient and add WithCodeT:

* add UsageT

* make extract

* translate messages in displayError
2019-07-17 15:19:49 -07:00
Sharif Elgamal 24ad1d82b9
Add test to make sure translations files are up to date. (#4777)
* Add test to make sure translations files are up to date.

* Fix file path sadness so tests work as expected

* make sure we reset the working dir

* switching from bytes.Compare to cmp.Diff

* add better error message

* extract new localized strings

* fix tests
2019-07-17 13:49:39 -07:00
Sharif Elgamal ad4d55f0ad
Merge branch 'master' of github.com:kubernetes/minikube into extract-advice 2019-07-10 10:24:36 -07:00
Sharif Elgamal c92e65ec28
Add templating for proper localization (#4677)
* Add templating for proper localization

* Fixing tests for new translation style

* checking errors is important

* fixing more console tests

* good function names make for happy developers

* add test for OutTemplateStyle

* short function names make for happy developers

* better formatting

* more better variable names
2019-07-10 10:17:28 -07:00
Sharif Elgamal fc9fc7eecd
initial commit for extracting advice strings 2019-07-09 15:48:26 -07:00
Sharif Elgamal 8a4776b250
Fixing top level extract call for new translations directory location 2019-06-24 15:18:31 -07:00
Sharif Elgamal 12bb8c5c25
Add translation files into the minikube binary 2019-06-24 15:15:01 -07:00