ed906c2d78
adding added files to automation for github package
2023-07-13 20:26:02 +00:00
aa0a915606
create separate message for internet search
2023-07-13 20:26:02 +00:00
6c9b4b21b7
refactor code and fix typos
2023-07-13 20:26:02 +00:00
7ebd7765e7
use GetReleaseByTag to speed up version searching
2023-07-13 20:26:02 +00:00
f0ba2185c5
add support for checking github k8s versions
2023-07-13 20:26:01 +00:00
42552bfc3d
adding added files to automation for github package
2023-07-13 20:11:33 +00:00
955d386541
path lint fix
2023-07-14 01:14:21 +05:30
4e2e2f233c
fix commit mail id
2023-07-14 00:28:11 +05:30
b8801c3306
Update cmd/minikube/cmd/root.go
2023-07-12 16:10:55 -07:00
164a522b60
Update cmd/minikube/cmd/root.go
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-07-13 06:39:32 +08:00
67c3d13f1f
Update cmd/minikube/cmd/root.go
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-07-13 06:36:09 +08:00
06fb28c2c3
chore: rename CheckPaused to VerifyNotPaused
2023-07-12 13:26:02 -07:00
5c46b3a555
make error message more clear
2023-07-12 13:25:17 -07:00
c205355974
create separate message for internet search
2023-07-12 19:53:27 +00:00
111acc8652
refactor code and fix typos
2023-07-12 19:27:36 +00:00
a3bf35384a
use GetReleaseByTag to speed up version searching
2023-07-12 17:10:52 +00:00
9502f96cae
fix lint
2023-07-12 10:01:12 -07:00
380359c0ef
feat: vmware driver support for new minikube iso
2023-07-12 09:40:01 -07:00
926cfe4469
Merge pull request #16789 from spowelljr/detectBlock
...
QEMU: Unblock bootpd if start fails to due to blocking
2023-07-11 15:40:52 -07:00
d1276604ad
fix lint error
2023-07-11 13:40:47 -07:00
54d1939b9b
add support for checking github k8s versions
2023-07-11 14:48:57 +00:00
47b5190e70
Merge branch 'master' into docker-env
2023-07-10 16:26:41 -07:00
d18f2762d7
Merge pull request #16850 from aiyijing/fix/unable-translate-group-msg
...
fix group message can't be translated
2023-07-10 12:15:56 -07:00
f601318df7
fix subcommand cannot be translated
...
Signed-off-by: aiyijing <aiyijing@live.com>
2023-07-09 22:54:25 +08:00
6d0c25e0c0
fix group message can't be translated
...
Signed-off-by: aiyijing <aiyijing@live.com>
2023-07-09 21:43:56 +08:00
763215d496
tunnel: Allow one tunnel per profile
2023-07-07 10:12:11 -07:00
a814542ad3
feat: use automated ssh-agent in docker-env
2023-07-07 00:35:43 +08:00
3d1b44055a
Add auto add-host and ssh-agent for docker-env
2023-07-02 02:52:41 +08:00
df8154a5e5
Apply suggestions from code review
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-07-02 02:08:43 +08:00
e1f77e8f40
Apply suggestions from code review
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-07-02 02:08:27 +08:00
c8d30c3331
Updating kicbase image to v0.0.39-1682028460-15452
2023-07-02 02:08:27 +08:00
508adea11f
feat: direct image build on containerd via docker-env
2023-07-02 02:08:27 +08:00
7ba7f7b868
Merge pull request #16761 from spowelljr/sshAgent
...
Add ability to start & stop ssh-agent process
2023-06-30 13:40:16 -07:00
6f881a7ed6
fix function name in comment
...
Signed-off-by: cui fliter <imcusg@gmail.com>
2023-06-28 11:59:22 +08:00
084630dfd3
Unblock bootpd if detected blocked
2023-06-26 14:13:53 -07:00
ca7e0fd59d
fix unset tests
2023-06-26 10:54:00 -07:00
78720ca145
add to SSH template
2023-06-26 10:13:29 -07:00
f417e18928
fix tests
2023-06-23 10:03:43 -07:00
78730bfaf8
fix name stuttering
2023-06-22 17:09:06 -07:00
f9c89f84e5
Add ability to start & stop ssh-agent process
2023-06-22 17:05:46 -07:00
6ef429550e
QEMU: Made firewall detction simplier and more robust
2023-06-22 14:57:39 -07:00
a209cfb661
Merge pull request #16714 from spowelljr/unblock
...
qemu on maos :Auto unblock bootpd from firewall for socket_vmnet network driver
2023-06-22 10:31:21 -07:00
29a32586a2
socket_vmnet: Auto unblock bootpd from firewall
2023-06-14 17:06:46 -07:00
cc91ebfd6f
Merge pull request #15003 from kpiljoong/fixes/13487
...
Fix to prevent accepting addons flag when no kubernetes
2023-06-14 11:58:41 -07:00
6d28d2aa5f
Fix kubectl tab-completion and improve error messages
...
Try to fix the following issues when `kubectl` is an alias for
`minikube kubectl --` and tab-completion for `kubectl` is enabled:
1. When `--cluster name` form of command-line option is used, it
conflicts with argument parsing, `name` is interpreted as plugin name.
Call to `kubectl --cluster test help` leads to error `Error: flags
cannot be placed before plugin name: --cluster`. Fix this by using
`--cluster=name` form, which is correctly handled also in call
`kubectl --cluster=test help`.
2. When `--cluster=name` is added as first argument (as seen in original
code), it still leads to error mentioned above when the command is
unknown like in the call `kubectl --cluster=test unknown`. Fix this by
inserting `--cluster=name` after all (sub-)commands and before any
flags/options.
3. The original code passed `--cluster=name` to normal `kubectl` calls,
but omitted it for tab-completion calls. This might lead to wrong tab
suggestions about pods, deployments and the like. Fix this by always
adding `--cluster=name` option to the command line.
4. In case of tab-completion, put the `--cluster=name` immediately after
`__complete` command to prevent any interference with incomplete
commands (just in case). This works fine and does not generate any
errors like mentioned in point 2.
2023-06-13 20:36:12 -07:00
8cf175ff81
update message
2023-06-13 09:48:47 -07:00
eb34e467af
change the message
2023-06-13 09:41:48 -07:00
5765b08ae3
Fix to prevent accepting addons flag when no kubernetes
2023-06-13 09:14:16 -07:00
4d85ac0cd7
Merge pull request #16671 from afbjorklund/docker-machine-reference
...
Remove extra references to docker machine
2023-06-12 13:33:36 -07:00
b1b4dbe4ab
Merge pull request #16670 from afbjorklund/vmwarefusion-removal
...
Remove the obsolete vmwarefusion driver
2023-06-12 13:26:46 -07:00
64df06f08a
Merge pull request #15079 from ComradeProgrammer/fix_14592
...
fix: quit minikube service when there is no available pods
2023-06-12 10:42:08 -07:00
18ff76add7
Merge pull request #15074 from ComradeProgrammer/fix_15007
...
fix: handle DOS-style path for Dockerfile in minikube build
2023-06-12 10:39:07 -07:00
c301dacf93
Remove extra references to docker machine
...
Should only use libmachine and the drivers
2023-06-11 14:35:40 +02:00
0a551357b4
Remove the obsolete vmwarefusion driver
...
It just referred to the "vmware" driver
2023-06-11 14:16:17 +02:00
1cc6c0a29c
Update cmd/minikube/cmd/service.go
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-06-10 21:43:08 +08:00
0bb29fe744
Update cmd/minikube/cmd/image.go
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-06-10 21:30:26 +08:00
76950ebdf0
fix: handle DOS-style path for Dockerfile in minikube build
2023-06-08 08:31:50 +08:00
12c4bf5f1d
Add ability to create extra disks on qemu2 vms
...
Add the ability to create and attach extra disks to qemu2 vms.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2023-06-06 16:28:19 -06:00
55868b1736
fix: quit minikube service when there is no available pods
2023-06-05 16:16:02 -07:00
7489d959a8
Merge pull request #16609 from spowelljr/changeAddonOwners
...
Update addon owners
2023-06-05 12:38:15 -07:00
37d82ecef4
Merge pull request #16610 from spowelljr/automateUpdatingKubernetesVersionsList
...
CI: Automate updating Kubernetes versions list
2023-06-05 12:37:40 -07:00
0168d63fc8
Merge pull request #16569 from JudahNour/addKubernetesVersions
...
--kubernetes-version: assume latest patch version if not specified by user
2023-06-01 10:50:20 -07:00
1079f9b631
CI: Automate updating Kubernetes versions list
2023-05-31 15:16:09 -07:00
5a1b0a14d6
update addon owners
2023-05-31 14:12:34 -07:00
852d9197a1
Refactored code and modified/added tests
2023-05-31 16:55:54 +00:00
c81a3172a4
Refactored code, updated error messages, and generated docs
2023-05-31 15:22:50 +00:00
c2c3f2996d
Add testing for isTwoDigitSemver and changed messages to user.
...
Corrected bug with version prefixes
2023-05-30 20:11:51 +00:00
e01610a0f3
Modified to alert user and exit when there is no associated patch
...
for the major.minor given
2023-05-25 21:51:35 +00:00
cbd577878e
--kubernetes-version: making case insensitive and refactoring handling
2023-05-24 20:26:58 +00:00
3afc728238
modified so alerts user that the patch version is assumed
2023-05-24 16:44:14 +00:00
b0892d0b8e
use ValidKubernetesVersions list for config defaults
2023-05-23 16:31:19 -07:00
a81e4f76ac
accept kubernetes version without patch version
2023-05-23 19:27:26 +00:00
dda802b332
none driver: fix image build
2023-04-26 18:57:16 -07:00
8931619b01
Applied suggestions
2023-04-25 15:11:41 +03:00
455bcb19ef
refactors removePid logic
2023-04-22 13:32:45 +03:00
aab0cb6d2a
Adds mechanism to remove pid from pidfile if mount is sigtermd
2023-04-22 00:50:00 +03:00
3d3e6a14e7
added stuff to reflect suggestions
2023-04-22 00:49:30 +03:00
b196ee46af
Apply suggestions from code review
2023-04-22 00:49:30 +03:00
0170981567
Saves us from passing func as parameter
...
:)
2023-04-22 00:49:30 +03:00
b09cd43e1d
Corrects style issue
2023-04-22 00:49:30 +03:00
8f50ee999a
Corrects mendacious comment
2023-04-22 00:49:30 +03:00
595c8eeeda
Adapts TestTryKillOne log for failing
2023-04-22 00:49:30 +03:00
82abc0dbee
Adapts unit test to new dependency
2023-04-22 00:49:30 +03:00
c55a4caacc
Adds the ownership check as a dependency
...
Otherway I see no obvious way to pass this check
during (say) unit testing
2023-04-22 00:49:30 +03:00
d72f2fb285
Changes pid owner conditional
...
What happened in the failed integration tests was that the starting
process was not "minikube", it was "minikube-linux-" and
"minikube-darwin-" instead.
2023-04-22 00:49:30 +03:00
ddec3100b9
Ensures sigkilling only minikube started processes
...
Adds a helper function to check that the executable name
is minikube.
2023-04-22 00:49:30 +03:00
b5e59b5db4
Renames sigkill function
2023-04-22 00:49:30 +03:00
1d5b316fda
Makes comment more clear
2023-04-22 00:49:30 +03:00
b368c64bb6
Update cmd/minikube/cmd/delete.go
2023-04-22 00:49:30 +03:00
db14047b65
Changes helper killProcess function name
2023-04-22 00:49:30 +03:00
43ff38b27d
Changes variable name in test
2023-04-22 00:49:30 +03:00
ee22b47795
Apply suggestions from code review
2023-04-22 00:49:30 +03:00
51e46b6d8d
Refactors GetPids
...
Moves GetPids inside cmd/delete.go as a helper function
Adds description
2023-04-22 00:49:30 +03:00
ead0b401ae
Changes name to unittest tool
2023-04-22 00:48:58 +03:00
badc971403
Adds source for cross platform killable process to test
...
As a way to clean the minikube repo dir.
2023-04-22 00:48:58 +03:00
b1bd26ab06
Adds unit test for new helper function tryKillOne
...
also adds that pleasedontkillme pkg, for the trykillone to be
tested against, so that we can run unit tests cross-platform:
no sure exec.Command("sleep", ....) is avail on windows...
2023-04-22 00:48:58 +03:00
3f47e72752
Modularizes killProcess()
...
adds helper functions for killing one process, given one pid
adds helper function to read pids out of a given pidfile
2023-04-22 00:48:34 +03:00
07d20708a5
Corrects error handling in killProcess
...
If we encountered just one err, we're returning it
If we're returning multiple errors, we're outing 'em
and return a multiple-errors error
2023-04-22 00:47:06 +03:00
9d4f296c1f
Adjusts mount processes cleaning logic
...
The delete mechanism called by the --kill flag logic
inside the minikube mount command, relies on a .mount-process file
inside the .minikube dotfolder in home directory.
For this to work, the mount should've been instantiated
by some mechanism that also creates the file; like
k8s.io/minikube/pkg/minikube/node.configureMounts()
To just add the local.WriteFile() logic from configureMounts()
is not enough for the usecase in #15778 :
user's consequent "minikube mount" calls would break the cleaning
logic, since the file's content gets overwritten at each new call.
So on subsequent minikube mounts, a call to "minikube mount
--kill=true" would remove just the last pid, leaving the other
mounts unaltered, and no trace of them in any place...(leak?)
For the same mechanism to work here,
we should rely on some local.AppendFile() function, to add
separated pids consequently.
This way only "minikube mount" would use this new append logic,
leaving unaltered the other functions.
We now have a new behaviour for the .mount-process file,
in order to address this, we should modify the delete logic from
cmd/minikube/cmd/delete.go -- killProcess(),
so that we can both kill a single pid, as well as multiple
space-separated pids in the same way.
...
Ah yes..
we're slightly modifying the "minikube mount" RunE anon function,
in order to write the pid into the .mount-process file;
as well as modifying cluster.Mount()'s signature to accept the pid.
That should be more than safe, since cluster.Mount() is used only here
2023-04-22 00:47:06 +03:00
c30c183dac
remove deprecated functions
2023-04-12 15:03:13 -07:00
Judah Nouriyelian
Sharran
Steven Powell
AiYijing
Tongyao Si
Steven Powell
Bogdan Luca
Medya Ghazizadeh
aiyijing
Товарищ программист
Товарищ программист
minikube-bot
cui fliter
Oldřich Jedlička
piljoong
Anders F Björklund
Blaine Gardner
x7upLime